Fix docker-compose Redis command interpolation and startup behavior#1101
Open
jdjingdian wants to merge 1 commit intoWei-Shaw:mainfrom
Open
Fix docker-compose Redis command interpolation and startup behavior#1101jdjingdian wants to merge 1 commit intoWei-Shaw:mainfrom
jdjingdian wants to merge 1 commit intoWei-Shaw:mainfrom
Conversation
d0f362d to
960b2bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where Docker Compose fails to parse the
commandfor the Redis service because Bash parameter expansion was interpreted as Compose interpolation. The change ensures the Redis startup command is passed to the container shell unchanged, and that the optional--requirepassflag is applied only whenREDIS_PASSWORDis provided.What I changed
Why
The original
commandused Bash's${REDIS_PASSWORD:+--requirepass "$REDIS_PASSWORD"}syntax. Docker Compose attempts to evaluate$-style interpolations itself and fails on this construct, leading to the error:Verification
before:
after:
Related issues