Skip to content

findAll: defer slips initialization (~20MB RAM savings) #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christopherkmoore wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

findAll: defer slips initialization (~20MB RAM savings) #2539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions addons/findAll/findAll.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,12 +192,20 @@ storages_order = S(res.bags:map(string.gsub-{' ', ''} .. string.lower ..

return index1 < index2
end)
local storage_slips_order = slips.storages:map(function(id)
return 'slip ' .. res.items[id].english:lower():match('^storage slip (.*)$')
end)
merged_storages_orders = storages_order + storage_slips_order + L{'key items'}
-- Deferred: slips iteration accesses res.items[id] for every slip, materializing
-- a large portion of the item database (~20MB). Build on first search instead.
merged_storages_orders = nil

local function ensure_merged_storages_orders()
if merged_storages_orders then return end
local storage_slips_order = slips.storages:map(function(id)
return 'slip ' .. res.items[id].english:lower():match('^storage slip (.*)$')
end)
merged_storages_orders = storages_order + storage_slips_order + L{'key items'}
end

function search(query, export)
function search(query, export)
ensure_merged_storages_orders()
update_global_storage()
update()
if query:length() == 0 then
Expand Down