Various fixes for patch 4 #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
A lot of this looks interesting, but this is way too much to change in a patch release. The only things that really need to be included in Patch 4 (as far as I'm aware) are crash fixes and security fixes. Maybe you can submit another PR including those only? Edit: I've now skimmed the entire changeset, and I do think most of these probably should be accepted in the long run -- it's just a matter of testing. There is a lot of extra bug surface getting introduced here and I'm not comfortable doing it in a Patch. Let's be surgical in our changes at this point. |
Contributor
Author
|
Do you have specific commits in mind which should be removed? |
Supermario1313
force-pushed
the
patch4-fixes
branch
from
d1b743d to
40731ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.