Conversation
There are currently some awful hacks like the creation of the SQL log ahead of time and the insertion of the `wcf1_package` row for the core itself to satisfy the foreign key checks. Also, the PHP-DDL is horribly slow at this time, easily taking 2 minutes to bootstrap the database vs. about 20 seconds before.
This was previously fetched twice for each table.
Allow passing of table data to the `process()` method while preserving the non-stale cached table structure between invocations.
This check will no longer pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
install.sqlto the PHP-DDL to keep it in sync with all other packages.SQLParserandsql-PIP in favor of the PHP-DDL.DatabaseTableChangeProcessorand add an option to efficiently and conveniently call it programmatically.install.sqlto keep the basicINSERTstatements around but execute them directly without parsing them.