Skip to content

Fix false positive for files with only require_once and class definitions#1369

Open
GeorgeWebDevCy wants to merge 4 commits into
WordPress:trunkfrom
GeorgeWebDevCy:fix/direct-file-access-require-once-false-positive
Open

Fix false positive for files with only require_once and class definitions#1369
GeorgeWebDevCy wants to merge 4 commits into
WordPress:trunkfrom
GeorgeWebDevCy:fix/direct-file-access-require-once-false-positive

Conversation

@GeorgeWebDevCy

@GeorgeWebDevCy GeorgeWebDevCy commented Jun 20, 2026

Copy link
Copy Markdown

Fixes #1361

Open WordPress Playground Preview

@github-actions

github-actions Bot commented Jun 20, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: GeorgeWebDevCy <orionaselite@git.wordpress.org>
Co-authored-by: davidperezgar <davidperez@git.wordpress.org>
Co-authored-by: marekdedic <marekdedic@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@davidperezgar

Copy link
Copy Markdown
Member

Thanks @GeorgeWebDevCy for your contribution. You need to review the tests that are failing before we can review the PR.

@GeorgeWebDevCy

Copy link
Copy Markdown
Author

Thanks for the heads up. I reviewed the failing tests and pushed a follow-up fix in 3813175. The CI matrix is now passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive missing_direct_file_access_protection for class files containing require_once

2 participants