Skip to content

Add trademark for-use regression test#1372

Open
GeorgeWebDevCy wants to merge 1 commit into
WordPress:trunkfrom
GeorgeWebDevCy:test/trademark-for-use-middle
Open

Add trademark for-use regression test#1372
GeorgeWebDevCy wants to merge 1 commit into
WordPress:trunkfrom
GeorgeWebDevCy:test/trademark-for-use-middle

Conversation

@GeorgeWebDevCy

@GeorgeWebDevCy GeorgeWebDevCy commented Jun 21, 2026

Copy link
Copy Markdown

Summary

  • Add a regression fixture for the plugin name reported in trademark check should allow "for" anywhere not only at end #977: Do Something for WooCommerce and Xyz.
  • Confirm that for WooCommerce is accepted when it appears in the middle of the plugin name.
  • Keep existing duplicate trademark coverage intact through the current bad-case fixture.

Fixes #977.

Testing

  • php -l tests/phpunit/tests/Checker/Checks/Trademarks_Check_Tests.php
  • php -l tests/phpunit/testdata/plugins/test-trademarks-plugin-header-for-woocommerce-middle/load.php
  • vendor/bin/phpcs --standard=phpcs.xml.dist tests/phpunit/tests/Checker/Checks/Trademarks_Check_Tests.php tests/phpunit/testdata/plugins/test-trademarks-plugin-header-for-woocommerce-middle/load.php
  • PHP 8.4 Docker harness against validate_name_has_no_trademarks(): issue example allowed; duplicate WooCommerce case still rejected.
Open WordPress Playground Preview

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: GeorgeWebDevCy <orionaselite@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: kkmuffme <kkmuffme@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trademark check should allow "for" anywhere not only at end

1 participant