Skip to content

Administration: Fix alignment of Recent Comments in the Activity widget.#11794

Open
itzmekhokan wants to merge 1 commit intoWordPress:trunkfrom
itzmekhokan:fix/65217-activity-section-alignment
Open

Administration: Fix alignment of Recent Comments in the Activity widget.#11794
itzmekhokan wants to merge 1 commit intoWordPress:trunkfrom
itzmekhokan:fix/65217-activity-section-alignment

Conversation

@itzmekhokan
Copy link
Copy Markdown

The #latest-comments container already has the .activity-block class which provides margin: 0 -12px 6px -12px and padding: 8px 12px 4px to extend the block edge-to-edge within #dashboard_activity .inside while keeping its inner content aligned with sibling activity blocks.

The additional margin: 0 -12px on #latest-comments #the-comment-list made the comment list and the comment-item backgrounds break out of the activity-block padding a second time, leaving the list horizontally misaligned with the sibling <h3> heading, the views (subsubsub) navigation, and the reply form output below it.

Removing the redundant negative margin lets the comment list respect the parent .activity-block padding, restoring consistent left/right alignment for all elements inside the Activity widget.

Fixes #65217.

Trac ticket: https://core.trac.wordpress.org/ticket/65217

The `#latest-comments` container already has the `.activity-block` class which provides `margin: 0 -12px 6px -12px` and `padding: 8px 12px 4px` to extend the block edge-to-edge within `#dashboard_activity .inside` while keeping its inner content aligned with sibling activity blocks.

The additional `margin: 0 -12px` on `#latest-comments #the-comment-list` made the comment list and the comment-item backgrounds break out of the activity-block padding a second time, leaving the list horizontally misaligned with the sibling `<h3>` heading, the views (subsubsub) navigation, and the reply form output below it.

Removing the redundant negative margin lets the comment list respect the parent `.activity-block` padding, restoring consistent left/right alignment for all elements inside the Activity widget.

Fixes #65217.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props khokansardar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant