Fix selected state for placeholder options in wp_dropdown_pages()#12281
Fix selected state for placeholder options in wp_dropdown_pages()#12281KarunyaChavan wants to merge 1 commit into
Conversation
…opdown_pages(). - Update `wp_dropdown_pages()` in `wp-includes/post-template.php` to apply the `selected()` helper to the `show_option_none` and `show_option_no_change` placeholder options. - Fixes an issue where saving and reloading the page with a placeholder option selected would cause the dropdown to reset its state. - Add unit tests in `tests/phpunit/tests/post/wpDropdownPages.php` to verify that both placeholder options correctly reflect their selected states.
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
1 participant
This PR fixes an issue in the
wp_dropdown_pages()function where theshow_option_noneandshow_option_no_changeplaceholder options would lose their selected state upon page reload. When a developer passed their respective values into theselectedargument, the dropdown would incorrectly default to the first position instead of marking the chosen placeholder as selected.Trac ticket: https://core.trac.wordpress.org/ticket/65510
What Changed?
wp_dropdown_pages()withinsrc/wp-includes/post-template.phpto include theselected()helper function on both theshow_option_noneandshow_option_no_changeHTML<option>tags.tests/phpunit/tests/post/wpDropdownPages.phpto verify that both placeholder options correctly reflect their selected states when their exact values are passed to the arguments array.