Skip to content

Always use a visible label and icon for the language switcher #12422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
himanshupathak95 wants to merge 9 commits into
base: trunk
Choose a base branch
from
+19 −15
Open

Always use a visible label and icon for the language switcher #12422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dc811f1
Unhide the "Language" text from `wp-login`
himanshupathak95 Jul 6, 2026
61ea285
Improve positioning of the text
himanshupathak95 Jul 6, 2026
887d203
Add the translation icon on `wp-signup` and `site-new`
himanshupathak95 Jul 6, 2026
567faa9
Use label first then the icon in `wp-login`
himanshupathak95 Jul 9, 2026
d0f54ef
Remove colon on field labels from `wp-signup`
himanshupathak95 Jul 9, 2026
4974a50
Remove hardcoded space
himanshupathak95 Jul 9, 2026
6a98cf7
Add styles for `wp-signup`
himanshupathak95 Jul 9, 2026
7c845e8
Add login page styles
himanshupathak95 Jul 9, 2026
716dd89
Add styles for settings and profile page
himanshupathak95 Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/wp-admin/css/common.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,6 +664,7 @@ code {

/* Dashicon for language options on General Settings and Profile screens */
.form-table th label[for="locale"] .dashicons,
.form-table th label[for="site-language"] .dashicons,
.form-table th label[for="WPLANG"] .dashicons {
margin-left: 5px;
}
Expand Down
9 changes: 8 additions & 1 deletion src/wp-admin/css/login.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,11 +446,18 @@ input::-ms-reveal {
text-align: center;
}

.language-switcher form {
display: inline-block;
}

.language-switcher label {
margin-right: 0.25em;
display: block;
margin-bottom: 0.5em;
Comment thread
himanshupathak95 marked this conversation as resolved.
text-align: left;
}

.language-switcher label .dashicons {
margin-left: 0.5em;
width: auto;
height: auto;
}
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/network/site-new.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@
if ( ! empty( $languages ) || ! empty( $translations ) ) :
?>
<tr class="form-field form-required">
<th scope="row"><label for="site-language"><?php _e( 'Site Language' ); ?></label></th>
<th scope="row"><label for="site-language"><?php _e( 'Site Language' ); ?><span class="dashicons dashicons-translation" aria-hidden="true"></span></label></th>
<td>
<?php
// Network default.
Expand Down
8 changes: 1 addition & 7 deletions src/wp-login.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,13 +377,7 @@ function login_footer( $input_id = '' ) {
<form id="language-switcher" method="get">

<label for="language-switcher-locales">
<span class="dashicons dashicons-translation" aria-hidden="true"></span>
<span class="screen-reader-text">
<?php
/* translators: Hidden accessibility text. */
_e( 'Language' );
?>
</span>
<?php _e( 'Language' ); ?><span class="dashicons dashicons-translation" aria-hidden="true"></span>
</label>

<?php
Expand Down
14 changes: 8 additions & 6 deletions src/wp-signup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ function wpmu_signup_stylesheet() {
.mu_register input[type="email"],
.mu_register #user_name { direction: ltr; }
.mu_register #site-language { display: block; }
.mu_register label[for="site-language"] .dashicons { margin-left: 0.5em; }
.mu_register .prefix_address,
.mu_register .suffix_address { font-size: 18px; display: inline-block; direction: ltr; }
.mu_register label,
Expand All @@ -91,6 +92,7 @@ function wpmu_signup_stylesheet() {
.mu_register .signup-options .wp-signup-radio-button { display: block; }
.mu_register .privacy-intro .wp-signup-radio-button { margin-right: 0.5em; }
.rtl .mu_register .wp-signup-blogname { direction: ltr; text-align: right; }
.rtl .mu_register label[for="site-language"] .dashicons { margin-right: 0.5em; margin-left: 0; }
</style>
<?php
}
Expand Down Expand Up @@ -125,9 +127,9 @@ function show_blog_form( $blogname = '', $blog_title = '', $errors = '' ) {
$current_network = get_network();
// Site name.
if ( ! is_subdomain_install() ) {
echo '<label for="blogname">' . __( 'Site Name (subdirectory only):' ) . '</label>';
echo '<label for="blogname">' . __( 'Site Name (subdirectory only)' ) . '</label>';
} else {
echo '<label for="blogname">' . __( 'Site Domain (subdomain only):' ) . '</label>';
echo '<label for="blogname">' . __( 'Site Domain (subdomain only)' ) . '</label>';
}

$errmsg_blogname = $errors->get_error_message( 'blogname' );
Expand Down Expand Up @@ -161,7 +163,7 @@ function show_blog_form( $blogname = '', $blog_title = '', $errors = '' ) {

// Site Title.
?>
<label for="blog_title"><?php _e( 'Site Title:' ); ?></label>
<label for="blog_title"><?php _e( 'Site Title' ); ?></label>
<?php
$errmsg_blog_title = $errors->get_error_message( 'blog_title' );
$errmsg_blog_title_aria = '';
Expand All @@ -179,7 +181,7 @@ function show_blog_form( $blogname = '', $blog_title = '', $errors = '' ) {
if ( ! empty( $languages ) ) :
?>
<p>
<label for="site-language"><?php _e( 'Site Language:' ); ?></label>
<label for="site-language"><?php _e( 'Site Language' ); ?><span class="dashicons dashicons-translation" aria-hidden="true"></span></label>
<?php
// Network default.
$lang = get_site_option( 'WPLANG' );
Expand Down Expand Up @@ -278,7 +280,7 @@ function show_user_form( $user_name = '', $user_email = '', $errors = '' ) {
}

// Username.
echo '<label for="user_name">' . __( 'Username:' ) . '</label>';
echo '<label for="user_name">' . __( 'Username' ) . '</label>';
$errmsg_username = $errors->get_error_message( 'user_name' );
$errmsg_username_aria = '';
if ( $errmsg_username ) {
Expand All @@ -291,7 +293,7 @@ function show_user_form( $user_name = '', $user_email = '', $errors = '' ) {

<?php
// Email address.
echo '<label for="user_email">' . __( 'Email&nbsp;Address:' ) . '</label>';
echo '<label for="user_email">' . __( 'Email&nbsp;Address' ) . '</label>';
$errmsg_email = $errors->get_error_message( 'user_email' );
$errmsg_email_aria = '';
if ( $errmsg_email ) {
Expand Down
Loading