Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Fixes the Twenty Nineteen Separator block so that Full width alignment actually spans the full page width, for both the Default and Wide Line styles. Currently the block's own
max-width/widthrules ignore thealignfullalignment entirely, so choosing Full width has no visible effect on the frontend and the separator is barely visible in the block editor.Frontend (
sass/blocks/_blocks.scss): the Separator block's ownmax-width: 2.25em(Default) and theis-style-wideboundedmax-widthwere never overridden when.alignfullwas applied. Added&.alignfull:not(.is-style-dots) { max-width: none; }so a full-width Default or Wide Line separator now spans edge-to-edge, matching the rest of the theme's full-width block handling. The Dots style is intentionally excluded, since it already renders at a deliberately bounded width.Editor (
style-editor.scss): the editor styles only set an explicitwidthfor the narrow Default style ($font__size-xl); nothing widened the separator when it carried thealignfullclass, which is why it appeared barely visible in the editor. Added&.alignfull:not(.is-style-dots) { width: 100%; }, placed after the narrow-width rule so it takes precedence when both classes are present.Note: the ticket's original 2022 patch also suggested adding a
block-editor-iframe__bodyselector to fix a missing editor margin; that generic fix already landed separately (visible atstyle-editor.scss:39) and covers this case, so no further change was needed there.Both compiled
style.cssandstyle-editor.csswere updated by hand to match, since this environment's Node toolchain couldn't rebuild the theme's SCSS vianode-sass(native build failure unrelated to this change); the added rules were hand-verified against the existing compiled output's formatting conventions.Manual verification: activated Twenty Nineteen locally and tested all four combinations directly in the running site (frontend + block editor, via computed styles and screenshots):
Trac ticket: https://core.trac.wordpress.org/ticket/59203
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5
Used for: Implementation and manual browser verification. Reviewed by Igor Rozum.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.