Repository navigation
Build/Test Tools: Run the invalid timezone E2E spec serially. - #15750
Open
lancewillett wants to merge 1 commit into
Open
lancewillett wants to merge 1 commit into
lancewillett wants to merge 1 commit into
Conversation
`general-settings-invalid-timezone.test.js` and `general-settings.test.js` both ran in the `parallel` project, and both submit the whole General Settings form, including the timezone the page loaded with. If `general-settings.test.js` saves between the timezone spec's two saves, the stored timezone goes back to its earlier value, and the timezone spec shows "UTC+0" instead of the timezone it just saved. This matches a failure in 7 of 58 parallel E2E jobs on 2026-11-06, each passing on retry. Move the timezone spec to the `serial` project, so the two specs no longer run at the same time. See #66455. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
lancewillett
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
general-settings-invalid-timezone.test.jsfrom theparallelproject to theserialproject.The "0" case of that spec passed only on retry in 7 of 58 parallel E2E jobs on 2026-11-06, across different PRs. Each time,
#timezone_stringshowed "UTC+0" instead of the timezone the test had just saved.general-settings.test.jsalso runs in theparallelproject, and it submits the whole General Settings form, including the timezone the page loaded with. If that save lands between the timezone spec's two saves,options.phpfalls back to the stored timezone, which is now the old one. This is the likely cause, not a confirmed one: the CI logs don't show when each test ran.With the timezone spec in
serial, the two specs can no longer run at the same time. Theparallelproject goes from 34 to 31 tests, andserialgoes from 72 to 75.Trac ticket: https://core.trac.wordpress.org/ticket/66455
Testing Instructions
npx playwright test -c tests/e2e/playwright.config.js --list --project=serialand confirm that it lists the 3 invalid timezone tests.--project=paralleland confirm that it does not list them.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Finding the retries in CI logs, the config change, and this description.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code