DRAFT: Refactor the sendMulti functions into a common method with callbacks#6132
Draft
DRAFT: Refactor the sendMulti functions into a common method with callbacks#6132
Conversation
ximinez
force-pushed
the
ximinez/lending-XLS-66-ongoing
branch
from
c6fcce0 to
b314566
Compare
ximinez
force-pushed
the
ximinez/lending-sendmulti
branch
from
7b36e5b to
f6f3542
Compare
…lending-sendmulti * commit '92046785d1fea5f9efe5a770d636792ea6cab78b': test: Fix the `xrpl.net` unit test using async read (6241) ci: Upload Conan recipes for develop, release candidates, and releases (6286) fix: Stop embedded tests from hanging on ARM by using `atomic_flag` (6248) fix: Remove DEFAULT fields that change to the default in associateAsset (6259) (6273) refactor: Update Boost to 1.90 (6280) refactor: clean up uses of `std::source_location` (6272) ci: Pass missing sanitizers input to actions (6266) ci: Properly propagate Conan credentials (6265) ci: Explicitly set version when exporting the Conan recipe (6264) ci: Use plus instead of hyphen for Conan recipe version suffix (6261) chore: Detect uninitialized variables in CMake files (6247) ci: Run on-trigger and on-pr when generate-version is modified (6257) refactor: Enforce 15-char limit and simplify labels for thread naming (6212) docs: Update Ripple Bug Bounty public key (6258) ci: Add missing commit hash to Conan recipe version (6256) fix: Include `<functional>` header in `Number.h` (6254) ci: Upload Conan recipe for merges into develop and commits to release (6235) Limit reply size on `TMGetObjectByHash` queries (6110) ci: remove 'master' branch as a trigger (6234) Improve ledger_entry lookups for fee, amendments, NUNL, and hashes (5644)
…lending-sendmulti * commit '5f638f55536def0d88b970d1018a465a238e55f4': chore: Set ColumnLimit to 120 in clang-format (6288)
…lending-sendmulti * commit '25cca465538a56cce501477f9e5e2c1c7ea2d84c': chore: Set clang-format width to 100 in config file (6387)
* commit '2c1fad1023': chore: Apply clang-format width 100 (6387)
…dmulti * XRPLF/develop: ci: [DEPENDABOT] bump actions/upload-artifact from 4.6.2 to 6.0.0 (6396) ci: [DEPENDABOT] bump actions/checkout from 4.3.0 to 6.0.2 (6397) ci: [DEPENDABOT] bump actions/setup-python from 5.6.0 to 6.2.0 (6395) ci: [DEPENDABOT] bump tj-actions/changed-files from 46.0.5 to 47.0.4 (6394) ci: [DEPENDABOT] bump codecov/codecov-action from 5.4.3 to 5.5.2 (6398) ci: Build docs in PRs and in private repos (6400) ci: Add dependabot config (6379) Fix tautological assertion (6393)
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
|
All conflicts have been resolved. Assigned reviewers can now start or resume their review. |
…dmulti * XRPLF/develop: (105 commits) fix: Handle WSClient write failure when server closes WebSocket (6671) ci: Change conditions for uploading artifacts in public/private/org repos (6734) refactor: Rename non-functional uses of `ripple(d)` to `xrpl(d)` (6676) refactor: Move more helper files into `libxrpl/ledger/helpers` (6731) fix: Minor RPC fixes (6730) fix: Prevent deletion of MPTokens with active escrow (6635) fix: Clamp VaultClawback to assetsAvailable for zero-amount clawback (6646) fix: Add assorted Lending Protocol fixes (6678) fix: Change variable signedness and correctly handle `std::optional` (6657) refactor: Reorganize RPC handler files (6628) chore: Update XRPLF/actions (6713) docs: Add explanatory comment to checkFee (6631) fix: Decouple reserve from fee in delegate payment (6568) fix: Check trustline limits for share-denominated vault withdrawals (6645) fix: Remove fatal assertion on Linux thread name truncation (6690) chore: Enable clang-tidy `coreguidelines` checks (6698) ci: Allow uploading artifacts for XRPLF org (6702) fix: Enforce aggregate MaximumAmount in multi-send MPT (6644) chore: Use nudb recipe from the upstream (6701) fix: Fix previous ledger size typo in RCLConsensus (6696) ...
ximinez
force-pushed
the
ximinez/lending-sendmulti
branch
from
25cca61 to
75d0960
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)