Skip to content

Conversation

@pratikmankawde
Copy link
Collaborator

temp PR for testing,

Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
- Added Address and Thread sanitizers for Debian Bookworm builds
- Updated build-deps action to support sanitizer flags
- Modified strategy matrix generation to include sanitizer configurations
- Updated Conan profiles for sanitizer support
- Added InsertNewlineAtEOF setting to clang-format
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
Signed-off-by: Pratik Mankawde <[email protected]>
@pratikmankawde pratikmankawde requested a review from a team as a code owner December 19, 2025 17:53
Comment on lines 119 to 153
run: |
cmake \
-G '${{ runner.os == 'Windows' && 'Visual Studio 17 2022' || 'Ninja' }}' \
-DCMAKE_TOOLCHAIN_FILE:FILEPATH=build/generators/conan_toolchain.cmake \
-DCMAKE_BUILD_TYPE="${BUILD_TYPE}" \
${CMAKE_ARGS} \
${{ inputs.cmake_args }} \
..
Copy link

@semgrep-companion-app semgrep-companion-app bot Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using variable interpolation ${{...}} with github context data in a run: step could allow an attacker to inject their own code into the runner. This would allow them to steal secrets and code. github context data can have arbitrary user input and should be treated as untrusted. Instead, use an intermediate environment variable with env: to store the data and use the environment variable in the run: script. Be sure to use double-quotes the environment variable, like this: "$ENVVAR".

🧁 Fixed in commit c702c74 🧁

Signed-off-by: Pratik Mankawde <[email protected]>
…/rippled into pratik/Add-sanitizers-to-CI-builds
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.1%. Comparing base (f80059e) to head (9049100).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6157     +/-   ##
=========================================
- Coverage     79.1%   79.1%   -0.0%     
=========================================
  Files          836     836             
  Lines        71257   71255      -2     
  Branches      8305    8322     +17     
=========================================
- Hits         56393   56363     -30     
- Misses       14864   14892     +28     
Files with missing lines Coverage Δ
src/libxrpl/ledger/View.cpp 94.5% <100.0%> (-<0.1%) ⬇️
src/libxrpl/protocol/BuildInfo.cpp 98.1% <ø> (ø)

... and 6 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vvysokikh1 vvysokikh1 added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Jan 2, 2026
@vvysokikh1 vvysokikh1 marked this pull request as draft January 2, 2026 16:08
@pratikmankawde pratikmankawde force-pushed the pratik/test-tsan-and-gcc14-asan branch from c702c74 to 9049100 Compare January 7, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DraftRunCI Normally CI does not run on draft PRs. This opts in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants