Repository navigation
fix(gds21): coerce invalid GDS datetimes to epoch - #1
Merged
Merged
Conversation
Add a regression that zeroes library and struct date fields and expects geometry to survive parse. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace panicking chrono date constructors in parse_datetimes with fallible opts and fall back to 1970-01-01 so bad metadata cannot abort library load. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GDS files with all-zero or otherwise invalid BGNLIB/BGNSTR timestamps made
gds21panic inside chrono. Geometry never reached the caller. Invalid dates now fall back to the Unix epoch so load can continue.What changed
parse_datetimesusesfrom_ymd_opt/and_hms_optand substitutes1970-01-01 00:00:00when a value is out of range.Scope
GdsDateTimesas requiredNaiveDateTimefields. Does not invent an unset/optional date API.Tradeoffs
Blast Radius
Verification
cargo test -p gds21 -- invalid_datetimes_preserve_geometrypasses.cargo test -p gds21passes (11 tests).cargo test --package gds --lib -- tests::test_gdsagainstOneDieBad.gdspasses.