Update LibFido2Swift for hardware key sign-in fix#3
Open
arifali123 wants to merge 1 commit into
Open
Conversation
arifali123
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates LibFido2Swift from
0.1.4to0.1.6in XcodesLoginKit.This is the upstream XcodesLoginKit dependency bump needed so XcodesApp can update and pick up the hardware security-key sign-in fix from LibFido2Swift.
Why
LibFido2Swift PR #6 fixes Apple ID hardware-key authentication when the authenticator returns a valid allow-list assertion without a WebAuthn
userHandle: kinoroy/LibFido2Swift#6That absence is valid for non-resident / server-side credentials, but the previous wrapper treated a null or empty user handle as
FIDO2Error.internalError. In XcodesApp this could fail after the user had already touched the hardware key, even though the assertion itself was otherwise valid.Impact
Once this lands in XcodesLoginKit and XcodesApp updates to it, XcodesApp can pick up the LibFido2Swift hardware-key fix and avoid the
internalErrorfailure path for Apple ID security-key sign-in.Package resolution now points LibFido2Swift at version
0.1.6, revisionac8596a852e2b008c5902a521cf4d9c7f0f05fba.