Clean CFLAGS-family and DEB_* environment before building the AMC firmware#79
Merged
quetric merged 2 commits intoXilinx:devfrom May 7, 2026
Merged
Conversation
Signed-off-by: Vlad Gabriel Serbu <Vlad-Gabriel.Serbu@amd.com>
Author
|
This should fix issue #66 |
Signed-off-by: Vlad Gabriel Serbu <Vlad-Gabriel.Serbu@amd.com>
Collaborator
|
lgtm |
hpc-aulmamei
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The debian package builder sets CFLAGS with x86-specific hardening options. For normal applications (such as the daemon or libvrt), this is normal and expected.
For the AMC firmware, this either causes the build to fail entirely, or, for the AMC firmware to stack overflow.
Fundamentally, the firmware compilation should be treated as separate, and the package builders should not inject any flags into the firmware build.
This PR unsets the environment variables before running the AMC build script.