Update xaie_txn.c for unused attributes#3
Closed
laurettaSchubert wants to merge 1 commit into
Closed
Conversation
Not working with clang compiler on Linux
ramanjan-amd
pushed a commit
that referenced
this pull request
May 12, 2026
Both static inline helpers had no callers anywhere in src/. The public-repo PR #3 silenced this by tagging them with __attribute__((unused)), but bare __attribute__ is unsupported on MSVC (see XAIE_PACK_ATTRIBUTE handling in src/common/xaie_helper.h) and would break the /Wall /WX build. Deleting the dead code is the portable equivalent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not working with clang compiler on Linux