Fix CI failures for macOS semaphore get_value workaround#5
Open
ice3 wants to merge 1 commit intosem-macosx-multiprocessing-module-Cfrom
Open
Fix CI failures for macOS semaphore get_value workaround#5ice3 wants to merge 1 commit intosem-macosx-multiprocessing-module-Cfrom
ice3 wants to merge 1 commit intosem-macosx-multiprocessing-module-Cfrom
Conversation
Collaborator
ice3
commented
Feb 27, 2026
- Add @critical_section to _get_value and _is_zero for free-threading safety
- Protect shm_semlock_counters check-then-act with PyMutex
- Handle NULL return from _is_zero_impl in _get_value_impl
- Remove non-static forward declaration conflicting with clinic
- Handle NULL/SEM_FAILED in exists_lock to avoid EINVAL from sem_trywait
- Remove debug dump_shm_macosx directory
- Add @critical_section to _get_value and _is_zero for free-threading safety - Protect shm_semlock_counters check-then-act with PyMutex - Handle NULL return from _is_zero_impl in _get_value_impl - Remove non-static forward declaration conflicting with clinic - Handle NULL/SEM_FAILED in exists_lock to avoid EINVAL from sem_trywait - Remove debug dump_shm_macosx directory Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.