Add --composite-rules flag to annotate multi license rules with required phrases#5118
Open
Kaushik-Kumar-CEG wants to merge 2 commits into
Open
Conversation
Author
|
@AyanSinhaMahapatra ready for review when you have a moment |
baa56a6 to
59026a3
Compare
Author
|
@AyanSinhaMahapatra please review when you have a moment :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
references #5077
Adds
--composite-rules(-c) flag to theadd-required-phrasesCLI command.For composite (AND/OR) rules, parses the expression into individual license keys, builds a per-key mapping of candidate phrases from license attributes (name, short_name, spdx_license_key) and is_required_phrase rules, then marks the rule only if ALL keys have at least one matching phrase in the text.
Uses existing infrastructure:
find_phrase_spans_in_textfor token-based matching,add_required_phrase_to_rulefor safe injection with overlap/ignorable checks,get_updatable_rules_by_expressionfor rule filtering.Usage:
Results: 1071 composite rules annotated in dry-run.
Tasks