Conversation
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
smorimoto
force-pushed
the
es-toolkit
branch
2 times, most recently
from
b7369c3 to
0d20549
Compare
Signed-off-by: Sora Morimoto <sora@morimoto.io>
smorimoto
force-pushed
the
es-toolkit
branch
from
0d20549 to
0da40e4
Compare
smorimoto
added a commit
that referenced
this pull request
Feb 14, 2026
…peConstructs The lodash-to-es-toolkit migration (#1562) replaced the objectAssign utility with Object.assign, which silently broke two behaviours: 1. Function-form arguments were no longer invoked with the current struct — they were merged as raw function objects instead. 2. Deep merging was lost — partially overriding a nested key like primitiveTypes.string would clobber sibling defaults ($default, date-time, etc.) and cause runtime crashes. Restore objectAssign rewritten atop es-toolkit's merge, and widen the public types for codeGenConstructs/primitiveTypeConstructs to accept both function and plain-object forms. Closes #1614
smorimoto
added a commit
that referenced
this pull request
Feb 14, 2026
…peConstructs The lodash-to-es-toolkit migration (#1562) replaced the objectAssign utility with Object.assign, which silently broke two behaviours: 1. Function-form arguments were no longer invoked with the current struct — they were merged as raw function objects instead. 2. Deep merging was lost — partially overriding a nested key like primitiveTypes.string would clobber sibling defaults ($default, date-time, etc.) and cause runtime crashes. Restore objectAssign rewritten atop es-toolkit's merge, and widen the public types for codeGenConstructs/primitiveTypeConstructs to accept both function and plain-object forms. Closes #1614
smorimoto
added a commit
that referenced
this pull request
Feb 14, 2026
…peConstructs (#1620) * Restore objectAssign utility to fix codeGenConstructs and primitiveTypeConstructs The lodash-to-es-toolkit migration (#1562) replaced the objectAssign utility with Object.assign, which silently broke two behaviours: 1. Function-form arguments were no longer invoked with the current struct — they were merged as raw function objects instead. 2. Deep merging was lost — partially overriding a nested key like primitiveTypes.string would clobber sibling defaults ($default, date-time, etc.) and cause runtime crashes. Restore objectAssign rewritten atop es-toolkit's merge, and widen the public types for codeGenConstructs/primitiveTypeConstructs to accept both function and plain-object forms. Closes #1614 * Guard against nullish updater return in objectAssign When a function-form updater returns undefined or null (e.g. a callback that mutates in place without an explicit return), Object.entries(update) would throw. Add a nullish check after invoking the updater so these cases are treated as no-ops, matching the original lodash-based behaviour. * Use PartialDeep for codeGenConstructs and primitiveTypeConstructs options Partial<T> is shallow, so nested override objects still required full nested shapes (e.g. Keyword needed every keyword, string needed $default). Since objectAssign deep-merges via es-toolkit's merge(), the types should use PartialDeep from type-fest to match the runtime behavior and allow common partial nested overrides without casting to any.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Replaces lodash with
es-toolkitthroughout the codebase and removes custom helpers in favor of native/ES Toolkit utilities.lodashusages fores-toolkit/es-toolkit/compat(compact,merge,uniq,omit,camelCase,get,startCase,upperFirst), replaceobjectAssignwithObject.assign, and removeinternal-caseutil/lodash-compatand export as_to templates to preserve template compatibilitynanoidand usecrypto.randomUUID()(util/id.ts)Object.entriesloops,compactchecks, content-type handling), updated description formatting, and safer null/empty checksinternalCasenowcamelCase; various schema parsers/routers/walkers updated to es-toolkit equivalentstests/utils.ts, increasevitesttimeoutes-toolkit; removelodash,@types/lodash,nanoid; bumpesbuild/rollup/viteand related transitive depsWritten by Cursor Bugbot for commit 0da40e4. This will update automatically on new commits. Configure here.