Open
Conversation
- Replace XmlFileLoader with PhpFileLoader (XmlFileLoader removed in SF8) - Convert services.xml to services.php using Configurator pattern - Add #[AsCommand] attribute to CreateCommand and ImportCommand - Add : void return type to configure() methods - Remove deprecated $defaultName static property from commands - Update composer.json constraints to support Symfony ^8.0 - Update PHP requirement to ^8.1 - Support typesense-php ^6.0 alongside ^4.5 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds full Symfony 8 compatibility to the TypesenseBundle:
XmlFileLoaderwithPhpFileLoader—XmlFileLoaderis removed in Symfony 8. Service definitions are now inservices.phpusing the Configurator pattern.#[AsCommand]attribute toCreateCommandandImportCommand— the deprecated$defaultNamestatic property is removed.: voidreturn type toconfigure()methods — required by Symfony 8's stricter type enforcement.composer.jsonconstraints — supportsymfony/*^8.0, PHP^8.1, andtypesense/typesense-php^6.0.Backward compatibility
#[AsCommand]is supported since Symfony 6.1 (and ignored on earlier versions)Changes
composer.jsonsrc/Command/CreateCommand.php#[AsCommand], removed$defaultName,configure(): voidsrc/Command/ImportCommand.php#[AsCommand], removed$defaultName,configure(): voidsrc/DependencyInjection/ACSEOTypesenseExtension.phpPhpFileLoaderinstead ofXmlFileLoadersrc/Resources/config/services.phpsrc/Resources/config/services.xmlContext
PR #149 (merged) updated
composer.jsonconstraints to allow SF8 but didn't address actual code incompatibilities. This PR fixes the remaining runtime issues that prevented the bundle from booting on Symfony 8.🤖 Generated with Claude Code