Skip to content

bug: legend stuck in highlight / selected state after chart click#725

Merged
c-lamoureux merged 7 commits intomainfrom
legend-stuck-on-highlight
Mar 9, 2026
Merged

bug: legend stuck in highlight / selected state after chart click#725
c-lamoureux merged 7 commits intomainfrom
legend-stuck-on-highlight

Conversation

@madelineluke
Copy link
Copy Markdown
Collaborator

@madelineluke madelineluke commented Mar 6, 2026

Description

When a user clicked on a chart mark and there was not a chart popover, the legend would get stuck in a selected state because the click was setting the selectedData refs unnecessarily.

Related Issue

Motivation and Context

This fix prevents the legend from ever getting in a "stuck" state after a chart click.

How Has This Been Tested?

All tests are passing, wrote unit tests, visual testing.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 9, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
90.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 9, 2026

@c-lamoureux c-lamoureux merged commit 7f8bf94 into main Mar 9, 2026
5 of 6 checks passed
@c-lamoureux c-lamoureux deleted the legend-stuck-on-highlight branch March 9, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants