bug: legend stuck in highlight / selected state after chart click#725
Merged
c-lamoureux merged 7 commits intomainfrom Mar 9, 2026
Merged
bug: legend stuck in highlight / selected state after chart click#725c-lamoureux merged 7 commits intomainfrom
c-lamoureux merged 7 commits intomainfrom
Conversation
…lick. going to update this logic and instead, don't set selectedData onMarkClick when there is not a popover
…s a popover on the mark
|
c-lamoureux
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
When a user clicked on a chart mark and there was not a chart popover, the legend would get stuck in a selected state because the click was setting the selectedData refs unnecessarily.
Related Issue
Motivation and Context
This fix prevents the legend from ever getting in a "stuck" state after a chart click.
How Has This Been Tested?
All tests are passing, wrote unit tests, visual testing.
Screenshots (if appropriate):
Types of changes
Checklist: