chore: upgrade oxlint to 1.70.0 and enable react/react-compiler rule#10203
Open
reidbarber wants to merge 7 commits into
Open
chore: upgrade oxlint to 1.70.0 and enable react/react-compiler rule#10203reidbarber wants to merge 7 commits into
reidbarber wants to merge 7 commits into
Conversation
|
Build successful! 🎉 |
reidbarber
changed the title
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [domRef, orientation, scale, setHasOverflow, children]); | ||
| // oxlint-enable react/react-compiler, react-hooks/exhaustive-deps |
Member
There was a problem hiding this comment.
this appears to be in the wrong place? and it looks like this happened in a number of places
Member
Author
There was a problem hiding this comment.
This is oxlint-enable, so it is re-enabling here. That being said, I think we can clean up some of these.
| let groupState = useContext(CheckboxGroupContext); | ||
| let {labelProps, inputProps, isInvalid, isDisabled} = groupState | ||
| ? // eslint-disable-next-line react-hooks/rules-of-hooks | ||
| // oxlint-disable-next-line react/react-compiler, react-hooks/rules-of-hooks |
Member
There was a problem hiding this comment.
the disable on the line above can probably be removed, this happened in a few places as well
|
Build successful! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades oxlint to 1.70.0, which includes the native react compiler rule.
Benchmark results on M4 Max MPB:
The native rule caught more violations than the JS plugin (585 total vs. 43 total).
Refs(ref access during render)Immutability(mutating props/hook values)Hooks(rules of hooks)CapitalizedCallsMemoDependenciesEffectSetStatePreserveManualMemoStaticComponents,Purity, etc.I suppressed them in this PR, but we can decide if there's any we want to fix for now.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: