Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
## API Changes
@react-spectrum/ai/@react-spectrum/ai:PromptField PromptField {
acceptedAttachmentTypes?: Array<string>
aiDisclaimer?: React.ReactNode
attachments?: Array<PromptFieldAttachment>
brandColor?: string
children: React.ReactNode
defaultAttachments?: Array<PromptFieldAttachment>
defaultValue?: PromptFieldValue
isGenerating?: boolean
+ isReadOnlyWhileGenerating?: boolean = false
onAITermsPress?: () => void
onAddAttachments?: (Array<PromptFieldAttachment>) => void
onAttachmentsChange?: (Array<PromptFieldAttachment>) => void
onChange?: (PromptFieldValue) => void
onStop?: () => void
onSubmit?: (PromptFieldValue, Array<PromptFieldAttachment>) => void
size?: 'S' | 'M' = 'M'
styles?: StyleString
value?: PromptFieldValue
variant?: 'balanced' | 'prominent' | 'subtle' = 'balanced'
}/@react-spectrum/ai:ExecutionTraceItem ExecutionTraceItem {
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
children: string
detail?: ReactNode
detailMaxHeight?: number = 120
icon?: ReactNode
id?: string
+ onExpandedChange?: (boolean) => void
status?: 'pending' | 'failed' | 'success'
styles?: StyleString
}/@react-spectrum/ai:PromptFieldProps PromptFieldProps {
acceptedAttachmentTypes?: Array<string>
aiDisclaimer?: React.ReactNode
attachments?: Array<PromptFieldAttachment>
brandColor?: string
children: React.ReactNode
defaultAttachments?: Array<PromptFieldAttachment>
defaultValue?: PromptFieldValue
isGenerating?: boolean
+ isReadOnlyWhileGenerating?: boolean = false
onAITermsPress?: () => void
onAddAttachments?: (Array<PromptFieldAttachment>) => void
onAttachmentsChange?: (Array<PromptFieldAttachment>) => void
onChange?: (PromptFieldValue) => void
onStop?: () => void
onSubmit?: (PromptFieldValue, Array<PromptFieldAttachment>) => void
size?: 'S' | 'M' = 'M'
styles?: StyleString
value?: PromptFieldValue
variant?: 'balanced' | 'prominent' | 'subtle' = 'balanced'
}/@react-spectrum/ai:ExecutionTraceItemProps ExecutionTraceItemProps {
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
children: string
detail?: ReactNode
detailMaxHeight?: number = 120
icon?: ReactNode
id?: string
+ onExpandedChange?: (boolean) => void
status?: 'pending' | 'failed' | 'success'
styles?: StyleString
}@react-spectrum/s2/@react-spectrum/s2:Menu Menu <T> {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
autoFocus?: boolean | FocusStrategy
children: ReactNode | (T) => ReactNode
defaultSelectedKeys?: 'all' | Iterable<Key>
dependencies?: ReadonlyArray<any>
disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
escapeKeyBehavior?: 'clearSelection' | 'none' = 'clearSelection'
hideLinkOutIcon?: boolean
id?: string
+ isVirtualized?: boolean = false
items?: Iterable<T>
loadingState?: LoadingState
onAction?: (Key, T) => void
onClose?: () => void
onSelectionChange?: (Selection) => void
selectedKeys?: 'all' | Iterable<Key>
selectionMode?: SelectionMode
shouldCloseOnSelect?: boolean
shouldFocusWrap?: boolean
size?: 'S' | 'M' | 'L' | 'XL' = 'M'
slot?: string | null
styles?: StylesProp
}/@react-spectrum/s2:MenuProps MenuProps <T> {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
autoFocus?: boolean | FocusStrategy
children: ReactNode | (T) => ReactNode
defaultSelectedKeys?: 'all' | Iterable<Key>
dependencies?: ReadonlyArray<any>
disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
escapeKeyBehavior?: 'clearSelection' | 'none' = 'clearSelection'
hideLinkOutIcon?: boolean
id?: string
+ isVirtualized?: boolean = false
items?: Iterable<T>
loadingState?: LoadingState
onAction?: (Key, T) => void
onClose?: () => void
onSelectionChange?: (Selection) => void
selectedKeys?: 'all' | Iterable<Key>
selectionMode?: SelectionMode
shouldCloseOnSelect?: boolean
shouldFocusWrap?: boolean
size?: 'S' | 'M' | 'L' | 'XL' = 'M'
slot?: string | null
styles?: StylesProp
} |
LFDanLu
marked this pull request as ready for review
September 21, 2026 23:06
LFDanLu
commented
Sep 21, 2026
| * | ||
| * @default false | ||
| */ | ||
| isReadOnlyWhileGenerating?: boolean; |
Member
Author
There was a problem hiding this comment.
this prop name sucks but I didn't want to call it "supportsSteering" or anything too specific. Not sure a better/shorter name tho
LFDanLu
commented
Sep 21, 2026
| new TokenFieldValue.SelectedRange( | ||
| {index: lastPlaceholder, offset: 0}, | ||
| {index: lastPlaceholder, offset: 1} | ||
| <div role="presentation" onKeyDown={onKeyDownProp}> |
Member
Author
There was a problem hiding this comment.
looks big, but this change is just a wrapping div
LFDanLu
commented
Sep 21, 2026
Member
Author
There was a problem hiding this comment.
just a fyi, many of the style changes/updates in here are basically taken from Picker/Combobox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from gaps found when using it in Coworker
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP