Skip to content

objectstorage: add request id and error code to S3's ServiceError - #4050

Open
burak-inherent wants to merge 1 commit into
agent-substrate:mainfrom
burak-inherent:objectstore-log-s3-error-details
Open

burak-inherent wants to merge 1 commit into
agent-substrate:mainfrom
burak-inherent:objectstore-log-s3-error-details

Conversation

@burak-inherent

@burak-inherent burak-inherent commented Nov 20, 2026 •

Copy link
Copy Markdown

RequestId and Code from S3 errors were ignored previously and logs were unhelpful to understand what failed when uploading snapshots to S3. With this change, we now get those in the logs.

Example log message before:

{
  "level":"WARN",
  "msg":"Object-store plugin failed with an unrecognized error; returning Internal",
  "http_status":403,
  "error_type":"*smithy.GenericAPIError"
}

After:

{
  "level":"WARN",
  "msg":"Object-store plugin failed with an unrecognized error; returning Internal",
  "http_status":403,
  "service_code":"AccessDenied",
  "request_id":"C3D8E1F0A9B27645",
  "error_type":"*smithy.GenericAPIError"
}

Related to #2661.

AI use: AI-assisted, I reviewed and tested it.

  • Tests pass
  • Docs updated

`RequestId` and `Code` from S3 errors were ignored previously and logs
were unhelpful to understand what failed when uploading snapshots to
S3. With this change, we now get those in the logs.

Signed-off-by: Burak Varli <burak@inherentlaboratories.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant