Skip to content

feat: align typed session failures with AIR protocol #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikita-ashihmin wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: align typed session failures with AIR protocol #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e03cf22
feat: expose warning-severity advisories for AIR (IJAI-993)
nikita-ashihmin Aug 12, 2026
eab146f
feat: route deprecationNotice through the advisory banner too
nikita-ashihmin Aug 12, 2026
e91c495
feat: align session failure metadata with AIR protocol
nikita-ashihmin Aug 13, 2026
ad3e2b8
fix: preserve Codex error messages in AIR metadata
nikita-ashihmin Aug 13, 2026
aa6ee42
fix: preserve typed failure incident lifecycle
nikita-ashihmin Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions src/CodexAcpServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,22 +134,24 @@ export interface SessionState {
}

export type SessionFailureCategory =
| "transport_lost" | "auth_required" | "rate_limited" | "quota_exhausted" | "overloaded"
| "context_exhausted" | "budget_exhausted" | "policy_denied" | "bad_request"
| "provider_error" | "internal_error";
| "connection" | "access" | "limit" | "request" | "service" | "unknown";

export type SessionFailureAction = "retry" | "reconnect" | "login" | "new_turn" | "new_session";
export type SessionFailureAction = "retry" | "login" | "new_session";

/**
* How loudly the client should render the record. Absent on the wire means `error`, so an AIR build
* that predates warning support keeps treating every record it receives as a failure.
*/
export type SessionFailureSeverity = "error" | "warning";

export interface SessionFailure {
id: string;
revision: number;
phase: "active" | "cleared";
category: SessionFailureCategory;
source: "codex";
safeMessage: string;
retryable: boolean;
severity: SessionFailureSeverity;
title: string;
details?: string;
actions: SessionFailureAction[];
turnId?: string;
}

const CODEX_PROCESS_EXITED_ERROR_CODE = 1001;
Expand Down Expand Up @@ -2044,9 +2046,10 @@ export class CodexAcpServer {
let eventHandler: CodexEventHandler | null = null;
let promptNotificationsActive = true;
const clearRecoveredSessionFailure = async (handler: CodexEventHandler): Promise<void> => {
await handler.completeSuccessfulTurn(sessionState.currentTurnId);
const current = sessionState.sessionFailure;
if (recoverableSessionFailure?.phase === "active"
&& current?.phase === "active"
if (recoverableSessionFailure !== undefined
&& current !== undefined
&& current.id === recoverableSessionFailure.id
&& current.revision === recoverableSessionFailure.revision) {
await handler.clearSessionFailure();
Expand Down Expand Up @@ -2372,8 +2375,10 @@ export class CodexAcpServer {
if (eventHandler !== null
&& clientSupportsTypedSessionFailures(this.clientCapabilities)
&& (isProcessExit || isUnexpectedFailure)) {
const category: SessionFailureCategory = isProcessExit ? "transport_lost" : "internal_error";
eventHandler.recordSyntheticTerminalFailure(category, sessionState.currentTurnId);
eventHandler.recordSyntheticTerminalFailure(
isProcessExit ? "transport_lost" : "internal_error",
sessionState.currentTurnId,
);
const failureResponse = this.terminalFailurePromptResponse(
sessionState,
eventHandler,
Expand Down
Loading