Skip to content

Conversation

@frostming
Copy link
Contributor

@frostming frostming commented Jan 8, 2026

fix: Eliminate the usage of type casting by making Agent/Client side connection fully compatible with the protocol.

Signed-off-by: Frost Ming [email protected]

Summary

Related issues

Fixes #49

Testing

Docs & screenshots

Checklist

  • Conventional Commit title (e.g. feat:, fix:).
  • Tests cover the change or are not required (explain above).
  • Docs/examples updated when behaviour is user-facing.
  • Schema regenerations (make gen-all) are called out if applicable.

fix: Eliminate the usage of type casting by making Agent/Client side connection fully compatible with the protocol.
Signed-off-by: Frost Ming <[email protected]>
Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@PsiACE PsiACE merged commit a7aa7c3 into agentclientprotocol:main Jan 8, 2026
8 checks passed
@frostming frostming deleted the fix/terminal-handle branch January 8, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: on_connect arg is AgentSideConnection at runtime while methods and params are different than Client

2 participants