Skip to content

Use pnpm catalogs for shared versions #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
venables merged 1 commit into from
Oct 29, 2025
Merged

Use pnpm catalogs for shared versions #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions demos/e2e/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
"dependencies": {
"@repo/cli-tools": "workspace:*",
"agentcommercekit": "workspace:*",
"valibot": "1.1.0",
"viem": "2.29.4"
"valibot": "catalog:",
"viem": "catalog:"
},
"devDependencies": {
"@repo/eslint-config": "workspace:*",
Expand Down
10 changes: 5 additions & 5 deletions demos/identity-a2a/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@
"test": "vitest"
},
"dependencies": {
"@a2a-js/sdk": "0.2.2",
"@a2a-js/sdk": "catalog:",
Copy link

@coderabbitai coderabbitai bot Oct 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify catalog definitions for all migrated packages.

Five packages have been migrated to catalog references: @a2a-js/sdk, jose, safe-stable-stringify, uuid, and valibot. Ensure all catalog entries are defined in pnpm-workspace.yaml.

Also applies to: 31-34

🏁 Script executed:

#!/bin/bash
# Description: Verify catalog definitions for identity-a2a packages

if [ -f "pnpm-workspace.yaml" ]; then
  echo "=== Checking for catalog definitions ==="
  cat pnpm-workspace.yaml | grep -E "@a2a-js/sdk:|jose:|safe-stable-stringify:|uuid:|valibot:"
else
  echo "ERROR: pnpm-workspace.yaml not found"
fi

Length of output: 118

Add missing catalog definition for @a2a-js/sdk to pnpm-workspace.yaml.

The package @a2a-js/sdk in demos/identity-a2a/package.json (line 27) references catalog: but has no corresponding entry in pnpm-workspace.yaml. The other four migrated packages (jose, safe-stable-stringify, uuid, valibot) are properly defined in the catalog, but @a2a-js/sdk is missing its definition.

🤖 Prompt for AI Agents 
In demos/identity-a2a/package.json around line 27, the dependency "@a2a-js/sdk":
"catalog:" references a catalog entry that is missing from pnpm-workspace.yaml;
add a corresponding catalog item in pnpm-workspace.yaml mapping "@a2a-js/sdk" to
its local package path (same style as the existing entries for jose,
safe-stable-stringify, uuid, valibot), commit the change, and run pnpm install
to verify the workspace resolves the package correctly.

Copy link
Contributor Author

@venables venables Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is referenced in pnpm-workspace.yaml. Check again.

Copy link

@coderabbitai coderabbitai bot Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check the full catalog section in pnpm-workspace.yaml
echo "=== Full pnpm-workspace.yaml content ==="
cat pnpm-workspace.yaml

Length of output: 503

@venables, you're absolutely right—I apologize for the error! Looking at the full pnpm-workspace.yaml, I can confirm that @a2a-js/sdk is indeed properly defined in the catalog section at version 0.2.2, along with all the other packages (jose, safe-stable-stringify, uuid, and valibot). The migration to catalog references is correctly configured. Thank you for the correction!

    (\\_/)
    (o.o)
    />📋< oops, my mistake!

"@repo/cli-tools": "workspace:*",
"agentcommercekit": "workspace:*",
"express": "4.21.2",
"jose": "6.0.11",
"safe-stable-stringify": "2.5.0",
"uuid": "11.1.0",
"valibot": "1.1.0"
"jose": "catalog:",
"safe-stable-stringify": "catalog:",
"uuid": "catalog:",
"valibot": "catalog:"
},
"devDependencies": {
"@repo/eslint-config": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion demos/identity-a2a/src/utils/server-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export function startAgentServer(

// Add DID document endpoint for did:web resolution
app.get("/.well-known/did.json", (req, res) => {
logger.log("🔍 Request for DID document:", colors.dim(req.url.toString()))
logger.log("🔍 Request for DID document:", colors.dim(req.url))
const didDocument = agent.didDocument
logger.log("🌐 Serving DID document for did:web resolution")
res.json(didDocument)
Expand Down
8 changes: 4 additions & 4 deletions demos/identity/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@
"@ai-sdk/anthropic": "1.2.11",
"@ai-sdk/openai": "1.3.22",
"@ai-sdk/valibot": "0.1.28",
"@hono/node-server": "1.14.2",
"@hono/valibot-validator": "0.5.2",
"@hono/node-server": "catalog:",
"@hono/standard-validator": "catalog:",
"@repo/api-utils": "workspace:*",
"@repo/cli-tools": "workspace:*",
"agentcommercekit": "workspace:*",
"ai": "4.3.16",
"hono": "4.7.10",
"valibot": "1.1.0"
"hono": "catalog:",
"valibot": "catalog:"
},
"devDependencies": {
"@repo/eslint-config": "workspace:*",
Expand Down
6 changes: 3 additions & 3 deletions demos/identity/src/serve-agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { serve } from "@hono/node-server"
import { vValidator } from "@hono/valibot-validator"
import { sValidator } from "@hono/standard-validator"
import { logger } from "@repo/api-utils/middleware/logger"
import { colors } from "@repo/cli-tools"
import { Hono } from "hono"
Expand All @@ -18,7 +18,7 @@ export function serveAgent({ port, agent }: ServeAgentConfig) {
app.use("*", logger())
app.post(
"/chat",
vValidator("json", v.object({ message: v.string() })),
sValidator("json", v.object({ message: v.string() })),
async (c) => {
const { message } = c.req.valid("json")

Expand All @@ -30,7 +30,7 @@ export function serveAgent({ port, agent }: ServeAgentConfig) {

app.post(
"/identity/challenge",
vValidator("json", v.object({ challenge: v.string() })),
sValidator("json", v.object({ challenge: v.string() })),
async (c) => {
const { challenge } = c.req.valid("json")

Expand Down
8 changes: 4 additions & 4 deletions demos/payments/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@
"test": "vitest"
},
"dependencies": {
"@hono/node-server": "1.14.2",
"@hono/node-server": "catalog:",
"@repo/api-utils": "workspace:*",
"@repo/cli-tools": "workspace:*",
"agentcommercekit": "workspace:*",
"hono": "4.7.10",
"valibot": "1.1.0",
"viem": "2.29.4"
"hono": "catalog:",
"valibot": "catalog:",
"viem": "catalog:"
},
"devDependencies": {
"@repo/eslint-config": "workspace:*",
Expand Down
4 changes: 2 additions & 2 deletions demos/skyfire-kya/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
"dependencies": {
"@repo/cli-tools": "workspace:*",
"agentcommercekit": "workspace:*",
"jose": "6.0.11",
"zod": "3.25.4"
"jose": "catalog:",
"zod": "catalog:"
},
"devDependencies": {
"@repo/eslint-config": "workspace:*",
Expand Down
4 changes: 2 additions & 2 deletions docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"docs": "mintlify dev"
},
"devDependencies": {
"mintlify": "4.0.538"
"mintlify": "4.2.183"
},
"packageManager": "pnpm@10.11.0"
"packageManager": "pnpm@10.20.0"
}
8 changes: 4 additions & 4 deletions examples/issuer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@
"test": "vitest"
},
"dependencies": {
"@hono/node-server": "1.14.2",
"@hono/node-server": "catalog:",
"@repo/api-utils": "workspace:*",
"agentcommercekit": "workspace:*",
"better-sqlite3": "11.10.0",
"bit-buffers": "1.0.2",
"bit-buffers": "catalog:",
"drizzle-orm": "0.43.1",
"hono": "4.7.10",
"valibot": "1.1.0"
"hono": "catalog:",
"valibot": "catalog:"
},
"devDependencies": {
"@repo/eslint-config": "workspace:*",
Expand Down
37 changes: 18 additions & 19 deletions examples/local-did-host/bin/serve.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,22 @@ serve(
hostname: process.env.HOSTNAME ?? "0.0.0.0",
port: parseInt(process.env.PORT ?? "3458"),
},
({ address, port }) =>
Promise.all([
getIdentityDid(buildUrl(address, port, "/agent")),
getIdentityDid(buildUrl(address, port, "/controller")),
]).then(([agent, controller]) => {
console.log(`> server running at http://${address}:${port}`)
console.table([
{
name: "Agent",
didUri: agent,
url: buildUrl(address, port, "/agent/.well-known/did.json"),
},
{
name: "Controller",
didUri: controller,
url: buildUrl(address, port, "/controller/.well-known/did.json"),
},
])
}),
({ address, port }) => {
const agent = getIdentityDid(buildUrl(address, port, "/agent"))
const controller = getIdentityDid(buildUrl(address, port, "/controller"))

console.log(`> server running at http://${address}:${port}`)
console.table([
{
name: "Agent",
didUri: agent,
url: buildUrl(address, port, "/agent/.well-known/did.json"),
},
{
name: "Controller",
didUri: controller,
url: buildUrl(address, port, "/controller/.well-known/did.json"),
},
])
},
)
8 changes: 4 additions & 4 deletions examples/local-did-host/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@
"@agentcommercekit/did": "workspace:*",
"@agentcommercekit/jwt": "workspace:*",
"@agentcommercekit/keys": "workspace:*",
"@hono/node-server": "1.14.2",
"@hono/valibot-validator": "0.5.2",
"@hono/node-server": "catalog:",
"@hono/standard-validator": "catalog:",
"@repo/api-utils": "workspace:*",
"hono": "4.7.10",
"valibot": "1.1.0"
"hono": "catalog:",
"valibot": "catalog:"
},
"devDependencies": {
"@repo/eslint-config": "workspace:*",
Expand Down
8 changes: 4 additions & 4 deletions examples/local-did-host/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { createJwt } from "@agentcommercekit/jwt"
import { vValidator } from "@hono/valibot-validator"
import { sValidator } from "@hono/standard-validator"
import { logger } from "@repo/api-utils/middleware/logger"
import { Hono } from "hono"
import * as v from "valibot"
Expand All @@ -15,7 +15,7 @@ app.use("*", identities())
*/
app.get(
"/:entity/.well-known/did.json",
vValidator(
sValidator(
"param",
v.object({
entity: v.picklist(["agent", "controller"]),
Expand All @@ -33,13 +33,13 @@ app.get(
*/
app.post(
"/:entity/sign",
vValidator(
sValidator(
"param",
v.object({
entity: v.picklist(["agent", "controller"]),
}),
),
vValidator(
sValidator(
"json",
v.object({
subject: v.string(),
Expand Down
3 changes: 2 additions & 1 deletion examples/local-did-host/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@
"@/*": ["src/*"]
}
},
"include": ["bin", "src", "vitest.config.ts"]
"include": ["**/*"],
"exclude": ["node_modules", "dist"]
}
8 changes: 4 additions & 4 deletions examples/verifier/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@
"test": "vitest"
},
"dependencies": {
"@hono/node-server": "1.14.2",
"@hono/valibot-validator": "0.5.2",
"@hono/node-server": "catalog:",
"@hono/standard-validator": "catalog:",
"@repo/api-utils": "workspace:*",
"agentcommercekit": "workspace:*",
"hono": "4.7.10",
"valibot": "1.1.0"
"hono": "catalog:",
"valibot": "catalog:"
},
"devDependencies": {
"@repo/eslint-config": "workspace:*",
Expand Down
9 changes: 2 additions & 7 deletions examples/verifier/src/routes/verify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { vValidator } from "@hono/valibot-validator"
import { sValidator } from "@hono/standard-validator"
import {
apiSuccessResponse,
type ApiResponse,
Expand All @@ -17,7 +17,6 @@ import {
jwtStringSchema,
} from "agentcommercekit/schemas/valibot"
import { Hono, type Env } from "hono"
import { ValiError } from "valibot"
import * as v from "valibot"

const app = new Hono<Env>()
Expand All @@ -33,11 +32,7 @@ const bodySchema = v.object({

app.post(
"/",
vValidator("json", bodySchema, (result) => {
if (!result.success) {
throw new ValiError(result.issues)
}
}),
sValidator("json", bodySchema),
async (c): Promise<ApiResponse<null>> => {
const resolver = getDidResolver()
let { credential } = c.req.valid("json")
Expand Down
22 changes: 11 additions & 11 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,23 +41,23 @@
},
"devDependencies": {
"@changesets/changelog-github": "0.5.1",
"@changesets/cli": "2.29.4",
"@changesets/cli": "2.29.7",
"@ianvs/prettier-plugin-sort-imports": "4.7.0",
"@prettier/plugin-oxc": "0.0.4",
"@repo/typescript-config": "workspace:*",
"@types/node": "22.18.13",
"dotenv-cli": "8.0.0",
"eslint": "9.27.0",
"@types/node": "24.9.2",
"dotenv-cli": "11.0.0",
"eslint": "9.38.0",
"prettier": "3.6.2",
"prettier-plugin-jsdoc": "1.3.3",
"prettier-plugin-jsdoc": "1.5.0",
"prettier-plugin-packagejson": "2.5.19",
"tsdown": "0.11.12",
"tsx": "4.19.4",
"turbo": "2.5.3",
"typescript": "5.7.3",
"vitest": "3.2.4"
"tsdown": "0.15.11",
"tsx": "4.20.6",
"turbo": "2.5.8",
"typescript": "5.9.3",
"vitest": "4.0.5"
},
"packageManager": "pnpm@10.11.0",
"packageManager": "pnpm@10.20.0",
"engines": {
"node": ">=22",
"pnpm": ">=10"
Expand Down
10 changes: 5 additions & 5 deletions packages/ack-id/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,15 @@
"@agentcommercekit/jwt": "workspace:*",
"@agentcommercekit/keys": "workspace:*",
"@agentcommercekit/vc": "workspace:*",
"safe-stable-stringify": "2.5.0",
"uuid": "11.1.0",
"valibot": "1.1.0"
"safe-stable-stringify": "catalog:",
"uuid": "catalog:",
"valibot": "catalog:"
},
"devDependencies": {
"@a2a-js/sdk": "0.2.2",
"@a2a-js/sdk": "catalog:",
"@repo/eslint-config": "workspace:*",
"@repo/typescript-config": "workspace:*",
"zod": "3.25.4"
"zod": "catalog:"
},
"peerDependencies": {
"@a2a-js/sdk": "^0.2.2",
Expand Down
4 changes: 2 additions & 2 deletions packages/ack-pay/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@
"@agentcommercekit/jwt": "workspace:*",
"@agentcommercekit/keys": "workspace:*",
"@agentcommercekit/vc": "workspace:*",
"valibot": "1.1.0"
"valibot": "catalog:"
},
"devDependencies": {
"@repo/eslint-config": "workspace:*",
"@repo/typescript-config": "workspace:*",
"zod": "3.25.4"
"zod": "catalog:"
},
"peerDependencies": {
"zod": "^3.25.0"
Expand Down
6 changes: 3 additions & 3 deletions packages/agentcommercekit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@
"@agentcommercekit/vc": "workspace:*"
},
"devDependencies": {
"@a2a-js/sdk": "0.2.2",
"@a2a-js/sdk": "catalog:",
"@repo/eslint-config": "workspace:*",
"@repo/typescript-config": "workspace:*",
"valibot": "1.1.0",
"zod": "3.25.4"
"valibot": "catalog:",
"zod": "catalog:"
},
"peerDependencies": {
"@a2a-js/sdk": "^0.2.2",
Expand Down
6 changes: 3 additions & 3 deletions packages/caip/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@
"devDependencies": {
"@repo/eslint-config": "workspace:*",
"@repo/typescript-config": "workspace:*",
"standard-parse": "0.3.0",
"valibot": "1.1.0",
"zod": "3.25.4"
"standard-parse": "catalog:",
"valibot": "catalog:",
"zod": "catalog:"
},
"peerDependencies": {
"valibot": "^1.1.0",
Expand Down
Loading