fix(dashscope): avoid 400 for non-streaming qwen3.5 multimodal requests#1003
Open
rrrjqy66 wants to merge 6 commits intoagentscope-ai:mainfrom
Open
fix(dashscope): avoid 400 for non-streaming qwen3.5 multimodal requests#1003rrrjqy66 wants to merge 6 commits intoagentscope-ai:mainfrom
rrrjqy66 wants to merge 6 commits intoagentscope-ai:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes DashScope HTTP 400 errors for non-streaming qwen3.5-* requests by explicitly disabling the model’s default “thinking mode” when streaming is off, and adds regression tests to ensure the correct endpoint and request parameters are used.
Changes:
- In
DashScopeChatModel, auto-disableenable_thinkingfor non-streaming requests when usingqwen3.5-*models (unless explicitly configured). - Add unit/integration-style tests to verify thinking is opted out and the multimodal endpoint is selected for
qwen3.5-plusnon-streaming calls.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| agentscope-core/src/main/java/io/agentscope/core/model/DashScopeChatModel.java | Adds model-name detection and forces enableThinking=false for non-streaming qwen3.5-* defaults. |
| agentscope-core/src/test/java/io/agentscope/core/model/DashScopeChatModelTest.java | Adds regression tests covering non-stream qwen3.5 thinking opt-out and multimodal endpoint selection. |
agentscope-core/src/main/java/io/agentscope/core/model/DashScopeChatModel.java
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
LearningGp
reviewed
Mar 24, 2026
agentscope-core/src/test/java/io/agentscope/core/model/DashScopeChatModelTest.java
Outdated
Show resolved
Hide resolved
…ts and wrap shutdown() in try-finally to avoid resource leaks
…ts and wrap shutdown() in try-finally to avoid resource leaks
rrrjqy66
commented
Mar 25, 2026
Author
rrrjqy66
left a comment
There was a problem hiding this comment.
Wrap shutdown() in a try-finally block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #984
AgentScope-Java Version
1.0.11
Description
Background
When
DashScopeChatModelis used withqwen3.5-plusin non-streaming mode, DashScope may return HTTP 400.At first glance this can look like an endpoint routing issue, but the multimodal endpoint is actually correct here. According to DashScope's Qwen 3.5 model behavior,
qwen3.5-plusshould still be treated as a multimodal model. The real problem is that Qwen 3.5 enables thinking by default, while thinking mode requires streaming. In the previous implementation, whenstream=falseandenableThinkingwas not explicitly set, the request did not explicitly disable thinking, which could cause DashScope to reject the request.Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)