Move AFNetworking to binary cocoapod#122
Open
thedavidharris wants to merge 1 commit intoairbnb:masterfrom
Open
Move AFNetworking to binary cocoapod#122thedavidharris wants to merge 1 commit intoairbnb:masterfrom
thedavidharris wants to merge 1 commit intoairbnb:masterfrom
Conversation
Collaborator
|
@thedavidharris Is there any code in the app that exercises this library? I'd love to make sure that there's a test that makes a network call with this binary library. Maybe https://swapi.co/ or something. |
Author
|
Just https://github.com/airbnb/BuckSample/blob/0a4a4d2919b05ba74da4791def260174556a06c0/Libraries/SwiftWithPrecompiledDependency/Sources/SwiftWithPrecompiledDependencyClass.swift, if there's probably an easier lib that could get used without dipping into networking to check things are working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #74, might not want to vendor the pods folder in this approach
make project)make debug)Tests didn't seem to be working on my machine, everything runs fine, was concerned about tests mostly for the embedding.