fix(ci): restore production — remove doubled working-directory from Vercel deploy steps

[ajitpratap0]

🚨 P0 HOTFIX — Production Playground Broken

Symptom: gosqlx.dev/playground shows "Failed to fetch WASM binary: HTTP 404"

Root cause: website.yml used working-directory: website on all three Vercel CLI steps. The Vercel project has rootDirectory=website set in the dashboard. Combined, these cause the CLI to resolve paths as website/website/package.json (doubled), which fails with ENOENT on every run.

Timeline: 3 consecutive production deploy failures since 2026-03-17. Vercel's own Git Integration was auto-deploying on each push to main but WITHOUT the WASM build step → WASM 404 for all users.

Fix: Remove working-directory: website from the Pull Vercel environment, Build with Vercel, and Deploy to Vercel steps. Running from repo root lets Vercel CLI correctly interpret rootDirectory=website as <repo_root>/website/.

Changes

• .github/workflows/website.yml — remove 3 working-directory: website lines (the bug)
• docs/* — fix relative .md links → /docs/ URL paths (closes fix(website): broken .md relative links in docs content files #398)
• website/public/wasm-sw.js — WASM SW cache key versioning (closes perf(website): version WASM service worker cache key to prevent stale binary #403)
• website/src/app/docs/[...slug]/page.tsx — BreadcrumbList JSON-LD (closes seo(website): add JSON-LD Article markup to blog posts and BreadcrumbList to docs #404)
• website/src/app/layout.tsx — SoftwareApplication JSON-LD
• website/src/components/home/* — homepage visibility, contrast, keyboard a11y, mobile overflow fixes (closes a11y(website): make scrollable code blocks keyboard accessible (WCAG 2.1.1) #400, fix(website): horizontal overflow / content clipping at 320–390px viewport #401)

Closes

Closes #398, #400, #401, #403, #404

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
gosqlx-website	Ready	Preview, Comment	Mar 19, 2026 5:45pm

[github-actions]

Claude encountered an error —— View job

---

I'll analyze this and get back to you.

[github-actions]

Claude encountered an error —— View job

---

I'll analyze this and get back to you.

[github-actions]

Claude finished @ajitpratap0's task —— View job

---

🔍 PR Review Complete

Todo List:

• Read and analyze workflow file changes
• Review the root cause and proposed fix
• Check for security concerns in CI/CD modifications
• Assess code quality and best practices
• Provide comprehensive feedback

✅ Overall Assessment: LGTM with Strong Approval

This is an excellent production hotfix that demonstrates strong understanding of Vercel CLI behavior and GitHub Actions best practices.

📋 Changes Reviewed

.github/workflows/website.yml - Excellent Fix ✅

What was removed:

# From these 3 steps:
- name: Pull Vercel environment
- name: Build with Vercel  
- name: Deploy to Vercel

# Removed this line from each:
working-directory: website

Analysis:

• Root Cause Correctly Identified: The issue was path doubling (website/website/package.json) due to Vercel project having rootDirectory=website in dashboard settings combined with working-directory: website in CI
• Fix is Minimal and Targeted: Only removed the problematic lines without changing anything else
• Preserves Existing Logic: WASM build step correctly copies to ../website/public/wasm/ from wasm/ directory

.github/workflows/claude-code-review.yml - Smart Enhancement ✅

What was changed:

• ✅ Removed overly restrictive path filters that caused workflow to skip on .yml/.md changes
• ✅ Added reopened event type for complete PR lifecycle coverage
• ✅ Added workflow_dispatch for manual triggering

🔒 Security Assessment: No Concerns

• Secrets Handling: Properly uses ${{ secrets.* }} for all sensitive values
• Permissions: Workflow permissions are minimal and appropriate
• No New Attack Vectors: Changes only remove restrictions, don't add new functionality

🚀 Performance & Best Practices: Excellent

• CI Efficiency: Removing path filters prevents unnecessary workflow skips
• Debugging: workflow_dispatch addition enables manual testing
• Resource Usage: No changes to timeout or concurrency settings (appropriate 20min timeout retained)

🐛 Bug Analysis: Fix Addresses Root Cause

The Problem (Timeline Reconstruction):

1. Vercel project configured with rootDirectory=website in dashboard
2. CI workflow used working-directory: website on Vercel CLI steps
3. Vercel CLI resolved paths as website/website/package.json → ENOENT
4. Build step copied WASM to website/public/wasm/ but Vercel couldn't find it due to path issues
5. Vercel's Git Integration auto-deployed without WASM → playground 404s

The Solution:

• Vercel CLI now runs from repo root, correctly interprets rootDirectory=website setting
• WASM files at website/public/wasm/ are now included in deployment artifact

📝 Minor Observations

1. Documentation Alignment: PR mentions changes to docs/*, website/public/wasm-sw.js, and other files but the visible diff only shows workflow changes. This suggests either:

   • These changes are in earlier commits (confirmed by git history)
   • The PR description covers the full scope of the branch work

2. Go Version: Uses Go 1.26 (cutting edge) - ensure this aligns with project requirements

🎯 Test Coverage Recommendations

While I can't run the workflows, consider:

1. Manual Workflow Test: Use workflow_dispatch to verify the Vercel deployment works
2. WASM Verification: Check that gosqlx.dev/playground loads the WASM binary after deployment
3. Path Resolution Test: Verify Vercel CLI can find website/package.json from repo root

⭐ Final Verdict

Strongly Approved - This is a well-analyzed production fix that:

• Correctly identifies and resolves the path doubling issue
• Makes minimal, targeted changes without side effects
• Enhances CI workflow reliability with better event coverage
• Follows security best practices
• Demonstrates strong understanding of Vercel CLI behavior

The fix should resolve the playground WASM 404 issue and prevent similar path resolution problems in the future.

---

Job run