fix: guard model registry lookup and prevent silent json serialization failure#458
Open
ELC1657 wants to merge 1 commit into
Open
fix: guard model registry lookup and prevent silent json serialization failure#458ELC1657 wants to merge 1 commit into
ELC1657 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two defensive fixes in the parallel execution path:
tools/streaming.py:_get_agent_token_info()used direct dictaccess (
ACTIVE_MODEL_INSTANCES[key]) which raisesKeyErrorif aweakref entry is garbage-collected between the emptiness check and the
lookup. The identical logic in
plan.pyalready uses.get()wrappedin
try/except— this makesstreaming.pyconsistent with that safepattern.
parallel_worker.py:json.dumpwas called without adefaultfallback. If any object in
message_historyis not JSON-serializable,the
TypeErroris caught by the file-write error handler and the entireworker result is silently lost. Added
default=strto match the patternused in
output.py.