Repository navigation
fix(critic): report clipfrac 0 when value_clip is not set - #513
Open
flyingdoubleG wants to merge 1 commit into
Open
flyingdoubleG wants to merge 1 commit into
flyingdoubleG wants to merge 1 commit into
Conversation
Without value_clip, CriticWorker.loss_func set vf_clipfrac = masked_mean(loss, ...), i.e. the squared value error, so the logged "critic/clipfrac" was the value loss rather than a fraction (it can exceed 1). Nothing is clipped in that branch; report 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In
CriticWorker.loss_func(roll/pipeline/base_worker.py), the branch withoutvalue_clipsetsso the logged
critic/clipfracis the squared value error (it duplicatescritic/errorand can exceed 1), not a clipped fraction. Nothing is clipped in this branch, so the fraction is 0; the change reports that. The loss and the other metrics are unchanged.Tests
tests/utils/test_critic_loss.pycallsloss_funcwith and withoutvalue_clipand checks the loss and thatcritic/clipfracis 0 / 1 respectively. The case withoutvalue_clipfails before the change (clipfrac 1.0 = the squared error) and passes after (CPU).🤖 Generated with Claude Code