Repository navigation
fix(sampler): renormalize only present domains - #514
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BatchStratifiedSamplerpruned absent domains fromself.domain_ratios, then rebuilt the mapping from the original argument. This reintroduced empty domains, causing iteration to divide by zero. Normalize the remaining weights after pruning so their relative proportions are preserved.Fixes #495.
PR #498 was closed unmerged by its author; the issue still reproduces on current
main.Validation
py -3.13 -m pytest -q -p no:cacheprovider tests/datasets/test_sampler.py— 7 passed (synthetic sampler tests; two existing torch/CUDA-version warnings).py -3.13 -m black --check roll/datasets/sampler.py tests/datasets/test_sampler.py— passed.git diff --check— passed.