Skip to content

fix: restrict SentinelResourceAspect pointcut to execution join points #3606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daguimu wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

fix: restrict SentinelResourceAspect pointcut to execution join points #3606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ctj/src/main/java/com/alibaba/csp/sentinel/annotation/aspectj/SentinelResourceAspect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
@Aspect
public class SentinelResourceAspect extends AbstractSentinelAspectSupport {

@Pointcut("@annotation(com.alibaba.csp.sentinel.annotation.SentinelResource)")
@Pointcut("execution(* *(..)) && @annotation(com.alibaba.csp.sentinel.annotation.SentinelResource)")

@oss-sentinel-ai oss-sentinel-ai Sep 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct fix. In native AspectJ (CTW/LTW), an unqualified @annotation(...) pointcut matches multiple join point kinds — including both call and execution — so the advice fires twice per invocation, double-counting SphU.entry() and breaking thread-based flow control. Restricting to execution(* *(..)) restores the intended single-firing semantics while remaining a no-op for Spring AOP users (proxy-based AOP only supports execution join points anyway).

Optional follow-up (non-blocking): if feasible, a regression test exercising the aspect under load-time weaving would guard against regressions, though that may be non-trivial to wire into the current test setup.

public void sentinelResourceAnnotationPointcut() {
}

Expand Down