-
Notifications
You must be signed in to change notification settings - Fork 1
Generate reference config from previous logs #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@alexandraBara have you checked if reference config file generated directly (--gen-reference-config) is identical to one generated from logs, assuming same "input" node? |
I have not, let me investigate |
The end files are the same. We will be adding this test to functional testing in the future to make sure it stays that way. |
landrews-amd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! added a couple suggestions
nodescraper/cli/cli.py
Outdated
| "--gen-reference-config-from-logs", | ||
| dest="reference_config_from_logs", | ||
| type=log_path_arg, | ||
| help="Generate reference config from previous run logfiles. Writes to ./reference_config.json.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should remove the 'Writes to ./reference_config.json.' part since we are now leveraging the output path arg
Scope: Use previous node-scraper logs to generate a reference config by parsing the log files.
node-scraper --gen-reference-config-from-logs <path_to_previous_logs>
Sample run:
Sample output:
reference_config.json:
README.md updates to follow