fix: Use valid syntax for conditionals (#254)

[kkozik-amplify]

by @tmccombs:

• fix: Use valid syntax for conditionals

Fix an issue where object literals inside conditional expressions were not rendered correctly, resulting in invalid expresions.

[kkozik-amplify]

Hey @tmccombs
I added round-trip test case in this commit based on the actual vs expected behavior you described in #253 and it doesn't pass.
Seems like your proposal wraps objects key in double quotes, which I don't believe is correct/expected inside an inline representation

[tmccombs]

which I don't believe is correct/expected inside an inline representation

Maybe I'm misunderstanding what you are saying, but why do you think that?

[tmccombs]

Here's a tofu console showing that using quoted strings in keys in inline objects is fine:

And if that isn't ok, that seems like a bug in how the to_tf_inline method serializes a dict.

[kkozik-amplify]

For example

  providers = {
    "aws.ue1" = aws
    aws.uw2 = aws.backup
  }

quoted references have been officialy deprecated.

Besides that, the library should still transform HCL2 to JSON faithfully without syntactic changes.

[kkozik-amplify]

that seems like a bug in how the to_tf_inline method serializes a dict.

Yeah this might be the case. If you would want to try pushing a fix for this, you could open a new PR to this branch. Otherwise let me know if I should close this PR.

[tmccombs]

quoted references have been officialy deprecated.

Do you have a source for that? I wasn't able to find anything.

[tmccombs]

FWIW, other epxressions with inline objects currently use double quotes as well:

>>> import hcl2
>>> hcl2.loads("""
... a {
...   x = merge({a = 2, b = "hello"}, var.more)
... }
... """)
{'a': [{'x': '${merge({"a": 2, "b": "hello"}, var.more)}'}]}

So, this change isn't really changing anything around that.

That said, is there any reason why to_tf_inline doesn't just do something like hcl2.writes(hcl2.reverse_transform(value))?