-
Notifications
You must be signed in to change notification settings - Fork 346
Fix build errors due to library and tool updates #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
-. Minimal changes to maintain compatibility with Android Studio 4.x
Summary of ChangesHello @HakimHauston, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves build errors and ensures the project's compatibility with Android Studio 4.x and newer development tools. It achieves this by updating core Android SDK versions, upgrading Gradle build tools, migrating to the latest Play Asset Delivery library APIs, and streamlining dependency management to use standard Maven repositories. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates various build configurations and dependencies to fix build errors, likely for compatibility with newer Android development tools. The changes include updating the Gradle plugin version, compile SDK version, and switching from a local Play Core Native SDK AAR to a Maven dependency. My review includes suggestions to update the target SDK version to meet Play Store requirements, remove an unnecessary Kotlin dependency, align a C++ function name with the new API it uses, and replace the deprecated jcenter() repository.
|
|
||
| android { | ||
| compileSdkVersion 28 | ||
| compileSdkVersion 34 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's great that you've updated compileSdkVersion to 34, the targetSdkVersion is still set to 28 (on line 29). This is very outdated and does not meet current Google Play requirements, which mandate targeting a recent API level (e.g., 33 or higher). To ensure your app is compliant and can leverage the latest platform improvements, you should also update targetSdkVersion to 34 to match compileSdkVersion.
| } | ||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:4.0.0-beta03' | ||
| classpath 'com.android.tools.build:gradle:4.0.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While updating the Android Gradle Plugin, it's a critical time to also address the use of jcenter() (line 21). JCenter has been sunset and is no longer a reliable repository, which can lead to build failures. Please replace jcenter() with mavenCentral() in both the buildscript and allprojects repository blocks to ensure future build stability.
| implementation 'com.google.android.play:asset-delivery:2.3.0' | ||
|
|
||
| // For Kotlin users also add the Kotlin extensions library for Play Asset Delivery: | ||
| implementation 'com.google.android.play:asset-delivery-ktx:2.3.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency adds the Kotlin extensions library for Play Asset Delivery. However, this project doesn't appear to use Kotlin (e.g., TeapotNativeActivity.java is a Java file, and the kotlin-android plugin isn't applied). To keep the app lightweight and avoid unused dependencies, it's recommended to remove this line.
| AssetPackManager_showConfirmationDialog(app->activity->clazz); | ||
| ShowConfirmationDialogStatus status; | ||
| AssetPackErrorCode error_code2 = | ||
| AssetPackManager_getShowCellularDataConfirmationStatus(&status); | ||
| AssetPackManager_getShowConfirmationDialogStatus(&status); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API calls here have been updated from ...showCellularDataConfirmation... to the more generic ...showConfirmationDialog.... However, the enclosing function is still named ShowCellularDataConfirmation (line 224), and the log message on line 232 also uses this old name. This creates a mismatch and can be confusing. For better code clarity and maintainability, consider renaming the function to ShowConfirmationDialog and updating the log message accordingly. This would also require updating the function declaration in PlayAssetDeliveryUtil.h and any call sites.
-. Minimal changes to maintain compatibility with Android Studio 4.x