chore: Fixed invalid quotes and typo in strings.xml#35
Conversation
Summary of ChangesHello @casper-jr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses minor but important clean-up in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes several issues in strings.xml. You've removed extraneous quotation marks that were causing XML validation errors and also corrected a typo in a string resource. These changes are accurate and improve the overall quality of the code. Great work!
cka-dev
left a comment
There was a problem hiding this comment.
Thanks for catching these.
lgtm
Hi, Thanks for a new sample application with Ink API!
I found a few typos in
strings.xmlwhere some<string>tags had trailing quotation marks outside the closing tag.This PR removes the extra quotes and a typo to fix the XML formatting.