AGP 9

[SimonMarquis]

This neat website can be used to track the current issues with AGP 9: https://agp-status.frybits.com/agp-9.0.0/

⚠️ TODO before merging PR

• Hilt Gradle Plugin does not work with AGP 9.0.0-alpha04 google/dagger#4944
  Temporary workaround with android.newDsl=false
• androidx.baselineprofile issue, flagged as error starting with AGP beta05:

  A problem occurred configuring project ':app'.
  > Using kotlin.sourceSets DSL to add Kotlin sources is not allowed with built-in Kotlin.
    Kotlin source set 'demoBenchmarkRelease' contains: [/home/runner/work/nowinandroid/nowinandroid/app/build/generated/ksp/demoBenchmarkRelease/kotlin, /home/runner/work/nowinandroid/nowinandroid/app/build/generated/ksp/demoBenchmarkRelease/java]
    Solution: Use android.sourceSets DSL instead.
    For more information, see https://developer.android.com/r/tools/built-in-kotlin
    To suppress this error, set android.disallowKotlinSourceSets=false in gradle.properties.
  

✅ Fixed issues

• Firebase Perf Plugin does not work with latest AGP 9 alpha firebase/firebase-android-sdk#7293 (fixed in Firebase BoM 34.5.0)
• AGP 9.0.0-alpha03 produces circular dependency on KSP tasks
  fixed in KSP 2.2.20-2.0.3
• Avoid using old Variant API extending JavaCompile task gradle/android-cache-fix-gradle-plugin#1886
  Temporary workaround with android.newDsl=false

  > Failed to apply plugin 'org.gradle.android.cache-fix'.
     > Could not get unknown property 'unitTestVariants' for object of type com.android.build.gradle.internal.dsl.ApplicationExtensionImpl$AgpDecorated.
  

• Regarding AGP 9 and built-in Kotlin. google/ksp#2615 (fixed in KSP 2.3.1-SNAPSHOT)
• release build type has isDebuggable forced to true, even when explicitly turned off.

  AGPBI: {"kind":"warning","text":"BuildType 'release' is both debuggable and has 'isMinifyEnabled' set to true.\nAll code optimizations and obfuscation are disabled for debuggable builds.","sources":[{}]}
  

  fixed in 52b118a
• Update to Gradle 9.2.0 to fix the issue

  WARNING: Unsupported Kotlin plugin version.
  The `embedded-kotlin` and `kotlin-dsl` plugins rely on features of Kotlin `2.2.0` that might work differently than in the requested version `2.2.10`.
  

[liutikas]

release build type has isDebuggable forced to true, even when explicitly turned off.

Can you point me to how to repro this?

[SimonMarquis]

I've not been able to reproduce it on my other projects, but on this one, simply build a release app with gradlew :app:assembleDemoRelease.

[SimonMarquis]

I found the issue, fixed in 52b118a.
enableAndroidTestCoverage forces the app to be debuggable, probably because of a new logic internal to AGP.

I've refactored the code to configure only the debug buildTypes:
https://github.com/SimonMarquis/nowinandroid/blob/52b118a1e073c07c4b7843e3ca93ea70333e41a0/build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Jacoco.kt#L68-L71

[liutikas]

Can you please rebase the merge conflicts?