Skip to content

Intent security skill#83

Open
sabs231 wants to merge 2 commits into
github-skillsfrom
intent-security-skill
Open

Intent security skill#83
sabs231 wants to merge 2 commits into
github-skillsfrom
intent-security-skill

Conversation

@sabs231

@sabs231 sabs231 commented Jun 22, 2026

Copy link
Copy Markdown

Add intent security skill

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new skill document, SKILL.md, outlining security best practices and code patterns for Android Intents and components. The reviewer provided valuable feedback addressing several technical inaccuracies in the guidelines: replacing the deprecated LocalBroadcastManager with modern in-app observers like Kotlin Flows or LiveData, correcting the usage of Binder.getCallingUid() which returns a UID rather than a package name directly, and noting that Binder.getCallingUid() cannot be used inside BroadcastReceiver.onReceive() to verify a sender's identity, suggesting protected system broadcasts or signature-level permissions instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread security/android-intent-security/SKILL.md Outdated
Comment thread security/android-intent-security/SKILL.md Outdated
Comment thread security/android-intent-security/SKILL.md Outdated
Comment thread security/android-intent-security/SKILL.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant