refactor(@angular/cli): decouple AnalyticsCollector from CommandContext
#32290
+17
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntext` The `AnalyticsCollector` class is made more modular and easier to test by removing its direct dependency on the `CommandContext`. Instead of accepting the entire context object, the constructor now receives only the specific dependencies it requires: the logger, user ID, and package manager information. This improves separation of concerns and simplifies unit testing of the analytics collector. Also removes a circular reference: packages/angular/cli/src/analytics/analytics-collector.ts → packages/angular/cli/src/command-builder/command-module.ts
clydin
force-pushed
the
cli/analytics-context-reduce
branch
from
33c4bb1 to
b299d6c
Compare
clydin
added
the
action: review
hybrist
approved these changes
Jan 14, 2026
| "packages/angular/build/src/tools/esbuild/utils.ts", | ||
| "packages/angular/build/src/utils/server-rendering/manifest.ts" | ||
| ], | ||
| [ |
clydin
added
action: merge
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AnalyticsCollectorclass is made more modular and easier to test by removing its direct dependency on theCommandContext. Instead of accepting the entire context object, the constructor now receives only the specific dependencies it requires: the logger, user ID, and package manager information.Also removes a circular reference:
packages/angular/cli/src/analytics/analytics-collector.ts→packages/angular/cli/src/command-builder/command-module.ts