Skip to content

test: simplify array option parsing test cases by consolidating multiple flag usages into a single flag with multiple values #32600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 3 commits into from
Feb 27, 2026
Merged

test: simplify array option parsing test cases by consolidating multiple flag usages into a single flag with multiple values #32600

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6434ee
test: simplify array option parsing test cases by consolidating multi…
alan-agius4 Feb 26, 2026
2d9572b
test: optimize `json-schema_spec.ts` by parsing the schema once in `b…
alan-agius4 Feb 26, 2026
e88eea9
test: add test cases for parsing array options specified multiple times
alan-agius4 Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 40 additions & 9 deletions packages/angular/cli/src/command-builder/utilities/json-schema_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import { JsonObject, schema } from '@angular-devkit/core';
import yargs from 'yargs';

import { addSchemaOptionsToCommand, parseJsonSchemaToOptions } from './json-schema';
import { Option, addSchemaOptionsToCommand, parseJsonSchemaToOptions } from './json-schema';

describe('parseJsonSchemaToOptions', () => {
describe('without required fields in schema', () => {
Expand All @@ -21,10 +21,9 @@ describe('parseJsonSchemaToOptions', () => {
};

let localYargs: yargs.Argv<unknown>;
beforeEach(async () => {
// Create a fresh yargs for each call. The yargs object is stateful and
// calling .parse multiple times on the same instance isn't safe.
localYargs = yargs().exitProcess(false).strict().fail(false).wrap(1_000);
let options: Option[];

beforeAll(async () => {
const jsonSchema = {
'type': 'object',
'properties': {
Expand Down Expand Up @@ -118,12 +117,20 @@ describe('parseJsonSchemaToOptions', () => {
},
},
};

const registry = new schema.CoreSchemaRegistry();
const options = await parseJsonSchemaToOptions(
options = await parseJsonSchemaToOptions(
registry,
jsonSchema as unknown as JsonObject,
false,
);
});

beforeEach(async () => {
// Create a fresh yargs for each call. The yargs object is stateful and
// calling .parse multiple times on the same instance isn't safe.
localYargs = yargs().exitProcess(false).strict().fail(false).wrap(1_000);

addSchemaOptionsToCommand(localYargs, options, true);
});

Expand All @@ -138,7 +145,15 @@ describe('parseJsonSchemaToOptions', () => {
});

describe('type=array, enum', () => {
it('parses valid option value', async () => {
it('parses valid option value when specified once', async () => {
expect(await parse(['--arrayWithChoices', 'always', 'never'])).toEqual(
jasmine.objectContaining({
'arrayWithChoices': ['always', 'never'],
}),
);
});

it('parses valid option value when specified multiple times', async () => {
expect(
await parse(['--arrayWithChoices', 'always', '--arrayWithChoices', 'never']),
).toEqual(
Expand All @@ -160,7 +175,15 @@ describe('parseJsonSchemaToOptions', () => {
});

describe('type=array, enum in oneOf', () => {
it('parses valid option value', async () => {
it('parses valid option value when specified once', async () => {
expect(await parse(['--arrayWithChoicesInOneOf', 'default', 'verbose'])).toEqual(
jasmine.objectContaining({
'arrayWithChoicesInOneOf': ['default', 'verbose'],
}),
);
});

it('parses valid option value when specified multiple times', async () => {
expect(
await parse([
'--arrayWithChoicesInOneOf',
Expand All @@ -183,7 +206,15 @@ describe('parseJsonSchemaToOptions', () => {
});

describe('type=array, anyOf', () => {
it('parses valid option value', async () => {
it('parses valid option value when specified once', async () => {
expect(await parse(['--arrayWithComplexAnyOf', 'default', 'something-else'])).toEqual(
jasmine.objectContaining({
'arrayWithComplexAnyOf': ['default', 'something-else'],
}),
);
});

it('parses valid option value when specified multiple times', async () => {
expect(
await parse([
'--arrayWithComplexAnyOf',
Expand Down