feat(@angular/build): add built-in SQLite cache store fallback#33499
Merged
Conversation
angular-robot
Bot
added
detected: feature
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new SQLite-backed persistent cache store (SqliteCacheStore) as a fallback for the native LMDB cache store, along with a unified PersistentCacheStore interface and factory initialization. Feedback focuses on improving robustness and performance: safely accessing error messages using optional chaining to prevent runtime TypeErrors, optimizing database operations by preparing and reusing SQL statements, wrapping cache parsing in a try-catch block to handle corruption, and properly cleaning up prepared statements upon closing the database.
clydin
force-pushed
the
feat-sqlite-cache-store
branch
from
aa5b08b to
58d93fa
Compare
To improve toolchain robustness in environments where native dependencies (like lmdb) fail to compile or load (e.g. Docker, locked-down CI environments), this change introduces a built-in SQLite cache store using Node.js v22's node:sqlite module.
clydin
force-pushed
the
feat-sqlite-cache-store
branch
from
58d93fa to
7ba63cd
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Jul 2, 2026
alan-agius4
added
action: merge
Collaborator
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve toolchain robustness in environments where native dependencies (like lmdb) fail to compile or load (e.g. Docker, locked-down CI environments), this change introduces a built-in SQLite cache store using Node.js v22's node:sqlite module.