fix(cdk/accordion): replace hardcoded colors with theme tokens#33388
Open
BHUVANSH855 wants to merge 1 commit into
Open
fix(cdk/accordion): replace hardcoded colors with theme tokens#33388BHUVANSH855 wants to merge 1 commit into
BHUVANSH855 wants to merge 1 commit into
Conversation
crisbeto
reviewed
Jun 13, 2026
| .example-accordion-item { | ||
| display: block; | ||
| border: solid 1px #ccc; | ||
| border: 1px solid var(--mat-sys-outline-variant); |
Member
There was a problem hiding this comment.
We intentionally don't use Material concepts in the CDK since the CDK is supposed to be independent of Material.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces hardcoded colors in the CDK accordion overview example with Material theme tokens.
Changes
#cccwith--mat-sys-outline-variantfor accordion item borders#999with--mat-sys-on-surface-variantfor description text#eeewith--mat-sys-surface-containerfor hover state stylingMotivation
The example used fixed color values that do not adapt to the active theme. Using Material theme tokens improves consistency across light and dark themes while preserving the existing appearance and behavior.