Skip to content

fix(cdk/overlay): allow users to opt into closing on any URL change - #33893

Merged
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:33665/overlay-url-change
Sep 29, 2026
Merged

fix(cdk/overlay): allow users to opt into closing on any URL change#33893
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:33665/overlay-url-change

Conversation

@crisbeto

@crisbeto crisbeto commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Expands the disposeOnNavigation config option to allow users to opt into closing on any URL change, not just popstate.

Fixes #33665.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Sep 29, 2026
@crisbeto
fix(cdk/overlay): allow users to opt into closing on any URL change
98615f3 
Expands the `disposeOnNavigation` config option to allow users to opt into closing on any URL change, not just popstate.

Fixes angular#33665.
@crisbeto
crisbeto force-pushed the 33665/overlay-url-change branch from ac54efa to 98615f3 Compare September 29, 2026 10:47
@crisbeto crisbeto changed the title fix(cdk/overlay): close on any URL change when disposeOnNavigation is enabled fix(cdk/overlay): allow users to opt into closing on any URL change Sep 29, 2026
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 29, 2026
@crisbeto
crisbeto merged commit 3de1f05 into angular:main Sep 29, 2026
29 of 31 checks passed
@crisbeto

crisbeto commented Sep 29, 2026

Copy link
Copy Markdown
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto added a commit that referenced this pull request Sep 29, 2026
@crisbeto
fix(cdk/overlay): allow users to opt into closing on any URL change (#…
1a434cd 
…33893)

Expands the `disposeOnNavigation` config option to allow users to opt into closing on any URL change, not just popstate.

Fixes #33665.

(cherry picked from commit 3de1f05)
@crisbeto crisbeto mentioned this pull request Sep 29, 2026
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ok7sai ok7sai ok7sai approved these changes
@andrewseguin andrewseguin Awaiting requested review from andrewseguin
@tjshiu tjshiu Awaiting requested review from tjshiu

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: cdk/overlay target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(overlay): backdrop click and open input stop closing cdkConnectedOverlay once the host view is detached (only Escape still works)

2 participants

@crisbeto @ok7sai