test(plugin): add tests for tool execution hooks#10043
Open
kynnyhsap wants to merge 2 commits intoanomalyco:devfrom
Open
test(plugin): add tests for tool execution hooks#10043kynnyhsap wants to merge 2 commits intoanomalyco:devfrom
kynnyhsap wants to merge 2 commits intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: Related PR:
However, #10028 is not a duplicate - it's adding a different hook (the No duplicate PRs found |
…r hooks Add comprehensive tests covering all use cases for tool execution hooks: tool.execute.before (6 tests): - Hook receives correct input parameters (tool, sessionID, callID) - Hook receives args in output - Hook can modify args - Hook can throw to block execution - Multiple hooks called sequentially with cumulative mutations - No hooks - output returned unchanged tool.execute.after (6 tests): - Hook receives correct input parameters - Hook receives result in output (title, output, metadata) - Hook can modify output text - Hook can modify title - Hook can modify metadata - Multiple hooks called sequentially
fd44384 to
6fcec08
Compare
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comprehensive tests for
tool.execute.beforeandtool.execute.afterplugin hooks.Fixes #10042
Tests Added
tool.execute.before(6 tests):tool.execute.after(6 tests):How verified
bun test test/plugin/tool-hooks.test.tsAll 12 tests pass.