fix(lsp): normalize Windows drive letter case for consistent URIs#10049
Open
yimingll wants to merge 1 commit intoanomalyco:devfrom
Open
fix(lsp): normalize Windows drive letter case for consistent URIs#10049yimingll wants to merge 1 commit intoanomalyco:devfrom
yimingll wants to merge 1 commit intoanomalyco:devfrom
Conversation
On Windows, drive letters are case-insensitive (D: == d:), but pathToFileURL() preserves the original casing. This causes URI mismatches when comparing URIs from different sources. Changes: - Add normalizePathForUri() to uppercase drive letters on Windows - Fix documentSymbol() to use fileURLToPath() instead of URL.pathname (URL.pathname returns /D:/path on Windows which is invalid) - Apply normalization to all LSP operations that generate file URIs Fixes: unresolvable URI error on Windows for lsp_document_symbols
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the "unresolvable URI" error on Windows when using LSP operations like
lsp_document_symbols,lsp_hover, etc.Problem
On Windows, drive letters are case-insensitive (
D:andd:refer to the same drive), but:pathToFileURL()preserves the original casing of the drive letterfile:///d:/pathbut internally tracksfile:///D:/path, it can't find the documentAdditionally,
URL.pathnameon Windows returns/D:/pathwith a leading slash, which is an invalid Windows path.Solution
normalizePathForUri()function that uppercases drive letters on Windows before converting to URInew URL(uri).pathnamewithfileURLToPath(uri)which properly handles Windows pathsChanges
packages/opencode/src/tool/lsp.ts: Normalize path before generating URI in the LSP toolpackages/opencode/src/lsp/index.ts:normalizePathForUri()helperdocumentSymbol()to usefileURLToPath()instead ofURL.pathnamehover(),definition(),references(),implementation(),prepareCallHierarchy(),incomingCalls(),outgoingCalls()Testing
Tested on Windows with clangd LSP server. Before this fix:
After this fix: