Skip to content

feat: Update ACP support, modernize and fix misc issues#25663

Merged
rekram1-node merged 8 commits intodevfrom
update-acp-sdk
May 7, 2026
Merged

feat: Update ACP support, modernize and fix misc issues#25663
rekram1-node merged 8 commits intodevfrom
update-acp-sdk

Conversation

@rekram1-node
Copy link
Copy Markdown
Collaborator

No description provided.

@rekram1-node
Copy link
Copy Markdown
Collaborator Author

/review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

lgtm

@rekram1-node rekram1-node changed the title chore: update acp sdk feat: Update ACP support, modernize and fix misc issues May 6, 2026
@rekram1-node
Copy link
Copy Markdown
Collaborator Author

/review

Comment thread packages/opencode/src/acp/agent.ts Outdated

const opencodeProvider = providers.find((p) => p.id === "opencode")
if (opencodeProvider) {
// if (opencodeProvider.models["claude-haiku-4-5"]) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion only; the human can decide whether to act on it. This looks like a temporary commented-out model override left behind in production code. Consider removing it so the default model fallback stays intentional and easy to audit.

@rekram1-node
Copy link
Copy Markdown
Collaborator Author

/review

Comment thread packages/opencode/src/acp/agent.ts
@rekram1-node
Copy link
Copy Markdown
Collaborator Author

/review

Comment thread packages/opencode/src/acp/agent.ts Outdated
@rekram1-node
Copy link
Copy Markdown
Collaborator Author

/review

Comment thread packages/opencode/src/acp/agent.ts
@rekram1-node
Copy link
Copy Markdown
Collaborator Author

/review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

lgtm

@rekram1-node rekram1-node merged commit b2e3dc8 into dev May 7, 2026
11 checks passed
@rekram1-node rekram1-node deleted the update-acp-sdk branch May 7, 2026 00:33
capyBearista pushed a commit to capyBearista/opencode that referenced this pull request May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant