fix(opencode): avoid rendering oversized snapshot diffs#29874
Open
Yoshi-OOF wants to merge 8 commits into
Open
fix(opencode): avoid rendering oversized snapshot diffs#29874Yoshi-OOF wants to merge 8 commits into
Yoshi-OOF wants to merge 8 commits into
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29873
Type of change
What does this PR do?
Prevents very large snapshot diffs from hanging session loading or diff rendering.
The snapshot service now skips oversized per-file patch text while keeping file, additions, deletions, and status metadata. The TUI also avoids rendering huge diff strings, and the web UI defers diff parsing until an expanded diff is actually shown.
How did you verify your code works?
bun typecheckinpackages/opencodebun typecheckinpackages/uibun test test/snapshot/snapshot.test.ts --timeout 30000 -t "diffFull omits patches that are too large to render safely"bun turbo typecheckvia pre-push hookcargo fmtin a Rust project with 64 unformatted files totaling several hundred thousand lines.Screenshots / recordings
N/A
Checklist